misc: finalized error message

backend/src/ee/services/group/group-service.ts

@@ -100,7 +100,7 @@ export const groupServiceFactory = ({
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
         message: constructPermissionErrorMessage(
-          "Failed to create a more privileged group",
+          "Failed to create group",
           membership.shouldUseNewPrivilegeSystem,
           OrgPermissionGroupActions.ManagePrivileges,
           OrgPermissionSubjects.Groups
@@ -185,7 +185,7 @@ export const groupServiceFactory = ({
         throw new ForbiddenRequestError({
           name: "PermissionBoundaryError",
           message: constructPermissionErrorMessage(
-            "Failed to update a more privileged group",
+            "Failed to update group",
             membership.shouldUseNewPrivilegeSystem,
             OrgPermissionGroupActions.ManagePrivileges,
             OrgPermissionSubjects.Groups

backend/src/ee/services/permission/permission-fns.ts

@@ -188,7 +188,9 @@ const constructPermissionErrorMessage = (
   opSubject: OrgPermissionSet[1] | ProjectPermissionSet[1]
 ) => {
   return `${baseMessage}${
-    shouldUseNewPrivilegeSystem ? `. Missing permission ${opAction as string} on ${opSubject as string}` : ""
+    shouldUseNewPrivilegeSystem
+      ? `. Missing permission ${opAction as string} on ${opSubject as string}`
+      : ". Privilege level is not high enough to perform this action"
   }`;
 };
 

backend/src/services/group-project/group-project-service.ts

@@ -116,7 +116,7 @@ export const groupProjectServiceFactory = ({
         throw new ForbiddenRequestError({
           name: "PermissionBoundaryError",
           message: constructPermissionErrorMessage(
-            "Failed to assign group to a more privileged role",
+            "Failed to assign group to role",
             membership.shouldUseNewPrivilegeSystem,
             ProjectPermissionGroupActions.ManagePrivileges,
             ProjectPermissionSub.Groups
@@ -294,7 +294,7 @@ export const groupProjectServiceFactory = ({
         throw new ForbiddenRequestError({
           name: "PermissionBoundaryError",
           message: constructPermissionErrorMessage(
-            "Failed to assign group to a more privileged role",
+            "Failed to assign group to role",
             membership.shouldUseNewPrivilegeSystem,
             ProjectPermissionGroupActions.ManagePrivileges,
             ProjectPermissionSub.Groups

backend/src/services/identity-project/identity-project-service.ts

@@ -104,7 +104,7 @@ export const identityProjectServiceFactory = ({
         throw new ForbiddenRequestError({
           name: "PermissionBoundaryError",
           message: constructPermissionErrorMessage(
-            "Failed to assign to a more privileged role",
+            "Failed to assign to role",
             membership.shouldUseNewPrivilegeSystem,
             ProjectPermissionIdentityActions.ManagePrivileges,
             ProjectPermissionSub.Identity
@@ -212,7 +212,7 @@ export const identityProjectServiceFactory = ({
         throw new ForbiddenRequestError({
           name: "PermissionBoundaryError",
           message: constructPermissionErrorMessage(
-            "Failed to change to a more privileged role",
+            "Failed to change role",
             membership.shouldUseNewPrivilegeSystem,
             ProjectPermissionIdentityActions.ManagePrivileges,
             ProjectPermissionSub.Identity

backend/src/services/identity-ua/identity-ua-service.ts

@@ -446,7 +446,7 @@ export const identityUaServiceFactory = ({
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
         message: constructPermissionErrorMessage(
-          "Failed to create client secret for a more privileged identity.",
+          "Failed to create client secret for identity.",
           membership.shouldUseNewPrivilegeSystem,
           OrgPermissionIdentityActions.CreateToken,
           OrgPermissionSubjects.Identity

backend/src/services/identity/identity-service.ts

@@ -78,7 +78,7 @@ export const identityServiceFactory = ({
       throw new ForbiddenRequestError({
         name: "PermissionBoundaryError",
         message: constructPermissionErrorMessage(
-          "Failed to create a more privileged identity",
+          "Failed to create identity",
           membership.shouldUseNewPrivilegeSystem,
           OrgPermissionIdentityActions.ManagePrivileges,
           OrgPermissionSubjects.Identity

backend/src/services/org/org-service.ts

@@ -951,7 +951,7 @@ export const orgServiceFactory = ({
             throw new ForbiddenRequestError({
               name: "PermissionBoundaryError",
               message: constructPermissionErrorMessage(
-                "Failed to invite user to a more privileged role in the project",
+                "Failed to invite user to the project",
                 membership.shouldUseNewPrivilegeSystem,
                 ProjectPermissionMemberActions.ManagePrivileges,
                 ProjectPermissionSub.Member

backend/src/services/project-membership/project-membership-service.ts

@@ -288,7 +288,7 @@ export const projectMembershipServiceFactory = ({
         throw new ForbiddenRequestError({
           name: "PermissionBoundaryError",
           message: constructPermissionErrorMessage(
-            `Failed to change to a more privileged role ${requestedRoleChange}`,
+            `Failed to change role ${requestedRoleChange}`,
             membership.shouldUseNewPrivilegeSystem,
             ProjectPermissionMemberActions.ManagePrivileges,
             ProjectPermissionSub.Member