feat(secret-sync): minor fixes

This commit is contained in:
carlosmonastyrski
2025-06-24 21:38:33 -03:00
parent c505c5877f
commit f462c3f85d
4 changed files with 18 additions and 11 deletions

View File

@@ -107,6 +107,10 @@ INF_APP_CONNECTION_GITHUB_APP_PRIVATE_KEY=
INF_APP_CONNECTION_GITHUB_APP_SLUG=
INF_APP_CONNECTION_GITHUB_APP_ID=
#gitlab app connection
INF_APP_CONNECTION_GITLAB_OAUTH_CLIENT_ID=
INF_APP_CONNECTION_GITLAB_OAUTH_CLIENT_SECRET=
#github radar app connection
INF_APP_CONNECTION_GITHUB_RADAR_APP_CLIENT_ID=
INF_APP_CONNECTION_GITHUB_RADAR_APP_CLIENT_SECRET=

View File

@@ -97,8 +97,8 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access
</Step>
<Step title="Configure Token">
<Tabs>
<Tab title="Secret Rotation">
For Secret Rotations, your token will require the ability to access the API:
<Tab title="Secret Sync">
For Secret Syncs, your token will require the ability to access the API:
Fill in the token details:
- **Token name**: A descriptive name for the token (e.g., "connection-token")
- **Expiration date**: Set an appropriate expiration date
@@ -107,6 +107,10 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access
![GitLab Personal Token Form](/images/app-connections/gitlab/gitlab-personal-access-token-form.png)
</Tab>
</Tabs>
<Info>
Personal Access Token connections require manual token rotation when your GitLab access token expires or is regenerated. Monitor your connection status and update the token as needed.
</Info>
</Step>
<Step title="Copy Token">
Copy the generated token immediately as it won't be shown again.
@@ -131,8 +135,8 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access
</Step>
<Step title="Configure Token">
<Tabs>
<Tab title="Secret Rotation">
For Secret Rotations, your token will require the ability to access the API and be at least an **Owner**:
<Tab title="Secret Sync">
For Secret Syncs, your token will require the ability to access the API and be at least an **Owner**:
Fill in the token details:
- **Token name**: A descriptive name for the token
- **Expiration date**: Set an appropriate expiration date
@@ -144,7 +148,7 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access
</Tabs>
<Info>
Access Token connections require manual token rotation when your GitLab access token expires or is regenerated. Monitor your connection status and update the token as needed.
Project Access Token connections require manual token rotation when your GitLab access token expires or is regenerated. Monitor your connection status and update the token as needed.
</Info>
</Step>
<Step title="Copy Token">
@@ -172,7 +176,7 @@ Infisical supports two methods for connecting to GitLab: **OAuth** and **Access
![Select GitLab Connection](/images/app-connections/gitlab/select-gitlab-connection.png)
</Step>
<Step title="Configure Access Token">
Select the **Access Token** method and paste your GitLab access token in the provided field. And select the appropriate token type.
Select the **Access Token** method, paste your GitLab access token in the provided field, and select the appropriate token type.
![Configure Access Token](/images/app-connections/gitlab/create-gitlab-access-token-connection.png)

View File

@@ -489,10 +489,10 @@ When set, all visits to the Infisical login page will automatically redirect use
<Accordion title="Gitlab">
Follow detailed guide to configure [GitLab SSO](/documentation/platform/sso/gitlab)
<ParamField query="INF_APP_CONNECTION_GITLAB_OAUTH_CLIENT_ID" type="string" default="none" optional>
<ParamField query="CLIENT_ID_GITLAB_LOGIN" type="string" default="none" optional>
OAuth2 client ID for GitLab login
</ParamField>
<ParamField query="INF_APP_CONNECTION_GITLAB_OAUTH_CLIENT_SECRET" type="string" default="none" optional>
<ParamField query="CLIENT_SECRET_GITLAB_LOGIN" type="string" default="none" optional>
OAuth2 client secret for GitLab login
</ParamField>
<ParamField query="URL_GITLAB_LOGIN" type="string" default="https://gitlab.com" optional>
@@ -591,11 +591,11 @@ You can configure third-party app connections for re-use across Infisical Projec
</Accordion>
<Accordion title="GitLab OAuth Connection">
<ParamField query="CLIENT_ID_GITLAB" type="string" default="none" optional>
<ParamField query="INF_APP_CONNECTION_GITLAB_OAUTH_CLIENT_ID" type="string" default="none" optional>
The Application ID of your GitLab OAuth application.
</ParamField>
<ParamField query="CLIENT_SECRET_GITLAB" type="string" default="none" optional>
<ParamField query="INF_APP_CONNECTION_GITLAB_OAUTH_CLIENT_SECRET" type="string" default="none" optional>
The Secret of your GitLab OAuth application.
</ParamField>

View File

@@ -516,7 +516,6 @@ export const OAuthCallbackPage = () => {
(async () => {
let data: { connectionId?: string; returnUrl?: string; appConnectionName?: string } | null =
null;
console.log("appConnection", appConnection);
if (appConnection === AppConnection.GitHub) {
data = await handleGithub();