github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-04-25 03:00:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

[eslint-config] [*] [fix] whitespace: only set erroring rules to "warn"

Browse Source 
Fixes #2105
This commit is contained in:
Jordan Harband
2019-12-10 16:32:17 -08:00
parent 2e3adc98c7
commit 370793b3dd
2 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/eslint-config-airbnb-base/whitespace.js
View File

@@ -4,6 +4,18 @@ const { CLIEngine } = require('eslint');
const baseConfig = require('.');
const severities = ['off', 'warn', 'error'];
function getSeverity(ruleConfig) {
if (Array.isArray(ruleConfig)) {
return getSeverity(ruleConfig[0]);
}
if (typeof ruleConfig === 'number') {
return severities[ruleConfig];
}
return ruleConfig;
}
function onlyErrorOnRules(rulesToError, config) {
const errorsOnly = assign({}, config);
const cli = new CLIEngine({ baseConfig: config, useEslintrc: false });
@@ -12,8 +24,9 @@ function onlyErrorOnRules(rulesToError, config) {
entries(baseRules).forEach((rule) => {
const ruleName = rule[0];
const ruleConfig = rule[1];
const severity = getSeverity(ruleConfig);
if (rulesToError.indexOf(ruleName) === -1) {
if (rulesToError.indexOf(ruleName) === -1 && severity === 'error') {
if (Array.isArray(ruleConfig)) {
errorsOnly.rules[ruleName] = ['warn'].concat(ruleConfig.slice(1));
} else if (typeof ruleConfig === 'number') {

15
packages/eslint-config-airbnb/whitespace.js
View File

@@ -4,6 +4,18 @@ const { CLIEngine } = require('eslint');
const baseConfig = require('.');
const severities = ['off', 'warn', 'error'];
function getSeverity(ruleConfig) {
if (Array.isArray(ruleConfig)) {
return getSeverity(ruleConfig[0]);
}
if (typeof ruleConfig === 'number') {
return severities[ruleConfig];
}
return ruleConfig;
}
function onlyErrorOnRules(rulesToError, config) {
const errorsOnly = assign({}, config);
const cli = new CLIEngine({ baseConfig: config, useEslintrc: false });
@@ -12,8 +24,9 @@ function onlyErrorOnRules(rulesToError, config) {
entries(baseRules).forEach((rule) => {
const ruleName = rule[0];
const ruleConfig = rule[1];
const severity = getSeverity(ruleConfig);
if (rulesToError.indexOf(ruleName) === -1) {
if (rulesToError.indexOf(ruleName) === -1 && severity === 'error') {
if (Array.isArray(ruleConfig)) {
errorsOnly.rules[ruleName] = ['warn'].concat(ruleConfig.slice(1));
} else if (typeof ruleConfig === 'number') {