mirror of
https://github.com/airbnb/javascript.git
synced 2026-04-25 03:00:19 -04:00
[eslint config] [breaking] enable react/require-render-return
This commit is contained in:
3
packages/eslint-config-airbnb/rules/react.js
vendored
3
packages/eslint-config-airbnb/rules/react.js
vendored
@@ -137,6 +137,9 @@ module.exports = {
|
||||
// Restrict file extensions that may be required
|
||||
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/require-extension.md
|
||||
'react/require-extension': [0, { 'extensions': ['.jsx'] }],
|
||||
// Require render() methods to return something
|
||||
// https://github.com/yannickcr/eslint-plugin-react/pull/502
|
||||
'react/require-render-return': 2,
|
||||
// Prevent extra closing tags for components without children
|
||||
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/self-closing-comp.md
|
||||
'react/self-closing-comp': 2,
|
||||
|
||||
@@ -399,6 +399,20 @@
|
||||
}
|
||||
```
|
||||
|
||||
- Be sure to return a value in your `render` methods. eslint: [`require-render-return`](https://github.com/yannickcr/eslint-plugin-react/pull/502)
|
||||
|
||||
```jsx
|
||||
// bad
|
||||
render() {
|
||||
(<div />);
|
||||
}
|
||||
|
||||
// good
|
||||
render() {
|
||||
return (<div />);
|
||||
}
|
||||
```
|
||||
|
||||
## Ordering
|
||||
|
||||
- Ordering for `class extends React.Component`:
|
||||
|
||||
Reference in New Issue
Block a user