github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-01-14 22:38:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

[eslint config] [base] [breaking] order of import statements is ignored for unassigned imports

Browse Source
This commit is contained in:
Josh Wells
2018-04-11 13:46:34 +01:00
committed by Jordan Harband
parent 2668495fee
commit b3bbd1ccbc
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/eslint-config-airbnb-base/rules/imports.js
View File

@@ -115,7 +115,7 @@ module.exports = {
// disallow non-import statements appearing before import statements
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/first.md
'import/first': ['error', 'absolute-first'],
'import/first': 'error',
// disallow non-import statements appearing before import statements
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/imports-first.md
@@ -139,13 +139,10 @@ module.exports = {
jsx: 'never',
}],
// Enforce a convention in module import order
// ensure absolute imports are above relative imports and that unassigned imports are ignored
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md
// TODO: enable?
'import/order': ['off', {
groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
'newlines-between': 'never',
}],
// TODO: enforce a stricter convention in module import order?
'import/order': ['error', { groups: [['builtin', 'external', 'internal']] }],
// Require a newline after the last import/require in a group
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md