114 Commits

Author SHA1 Message Date
Jordan Gensler
e9b1ef92bf Adding links to lint rules in react styleguide. 2015-12-11 23:00:10 -08:00
Maja Wichrowska
efe7507e65 export default should not be inline with the class declaration
When there are static variables like `propTypes` and `defaultProps`, we shouldn't export them until we have actually set them onto the `Component`. This may change if the current ES7 proposal for static class properties gets accepts, and we update to support it.
2015-10-20 17:31:01 -07:00
Kevin Cooper
ef7fbea3d9 Add further reasoning for using double quotes in JSX 2015-10-01 16:53:49 -07:00
Kevin Cooper
d4f69efeec Add reasoning for using double quotes in JSX 2015-10-01 15:11:17 -07:00
Jake Teton-Landis
c42275f5dd Merge pull request #491 from gilbox/react-terse-export-syntax
[react] inline export syntax
2015-09-16 16:08:56 +09:00
Jordan Harband
3307caf5a0 do not export propTypes
We decided to stick with the decision to not export `propTypes`, and leave them as only a static property on the default export.

/@josh-perez @gilbox
2015-08-28 13:57:30 -07:00
Gil Birman
1733557ac4 [react] inline export syntax 2015-08-28 11:15:32 -07:00
Dace Willmott
933b367e6c update spelling to clarify JSX rather than JS 2015-08-27 14:51:24 -04:00
Jordan Harband
c4fdbc2742 Recommend exporting propTypes as a named export
By exporting `propTypes` as a named export *as well* as attaching them to the "class", they can be explicitly imported by tests and other components in a way that aligns with the future ES6 module dependency graph, rather than as an arbitrary property that isn't statically verifiable. Doing both is great imo.

Thoughts?
2015-08-17 20:42:58 -07:00
Josh Perez
4b70374b9c Update React style guide with new rules
This formalizes the rules that we've been following for class extends React.Component and also updates our ordering with whats in the eslintrc file.
2015-07-16 10:42:26 -07:00
Horace Ko
d2792f27cb Recommend using .jsx extension for React components, rather than .js. 2015-06-25 11:54:22 -07:00
ycavatars
7a7bec17f3 add missing componentDidUpdate 2015-06-08 12:56:32 +08:00
Alvin Sng
2595cb6724 removed alpha sort, changed jsx exten to js, added method prefix rule, added camelCase for props 2015-04-30 13:08:58 -07:00
Alvin Sng
3764337df2 React/JSX Style Guide 2015-04-29 15:29:51 -07:00