Jordan Harband
0814be638f
[eslint config] [base] [deps] update eslint, eslint-find-rules
...
Adds disabled rules: `max-lines`, `no-mixed-operators`, `rest-spread-spacing`, `object-curly-newline`
2016-06-16 22:44:35 -07:00
hunyong-song
22f59b6e1b
Adding link korean translation
2016-06-16 10:20:03 +09:00
Andrzej Duś
defa17e872
Added Syzygy Warsaw
2016-06-15 11:25:19 +02:00
Caleb
90f5a47c33
Updated deprecated Japanese translation link.
...
old: https://github.com/mitsuruog/javacript-style-guide
new: https://github.com/mitsuruog/javascript-style-guide
2016-06-13 19:15:19 +10:00
Harrison Shoff
b4c49e9ec7
Merge pull request #909 from pietraszekl/patch-1
...
Adding link to polish translation
2016-06-12 00:16:34 -07:00
Lukasz Pietraszek
29eb575a52
Adding link polish translation
2016-06-11 09:39:03 +01:00
Jordan Harband
f41b4df024
[eslint config] [base] [breaking] enable no-prototype-builtins rule.
2016-06-04 18:14:02 -07:00
Jordan Harband
4700d99864
[eslint config] [base] [breaking] enable no-useless-rename rule
2016-06-04 18:00:02 -07:00
Jordan Harband
d9cb343b51
[eslint config] [base] [breaking] enable unicode-bom rule
2016-06-04 17:58:25 -07:00
Jordan Harband
ab4baf457e
[eslint config] [base] [deps] update eslint, eslint-plugin-import
2016-06-04 17:41:41 -07:00
Jordan Harband
89cfa0b81c
[eslint config] [*] use in-publish because coffeescript screwed up the prepublish script for everyone
2016-06-04 17:38:41 -07:00
Jordan Harband
eb76edea32
[eslint config] [*] [tests] Only run eslint-find-rules on prepublish, not in tests.
2016-06-04 17:30:00 -07:00
Wesley
3fb9db5a74
fixing broken link
...
Google moved their style guides to Github (from an SVN server), and this link was broken
2016-06-04 15:17:00 -07:00
Ross Kirsling
267eec57c6
Fix invalid code snippet in 23.2.
2016-06-02 10:24:30 -07:00
Simen Bekkhus
d97d62a2ff
Fix react dev dep version
2016-06-01 10:04:07 +02:00
mifi
1db5522888
Fix typo
...
disallowSpacesInsideObjectBrackets -> requireSpacesInsideObjectBrackets
2016-05-26 22:54:27 +02:00
Alanna Scott
c247fd754b
Avoid using an array index as key prop, prefer unique ID
2016-05-25 12:30:34 -07:00
Jordan Harband
4c4210f23d
Remove trailing whitespace.
2016-05-25 18:19:19 +02:00
Sergii Tkachenko
199a0a700d
Add DoSomething.org to the list of organizations in README
2016-05-25 17:49:40 +03:00
Jason
a8839173cc
add chinese simplified for React/JSX style guide
2016-05-25 16:50:37 +08:00
Jordan Harband
b6e4b72fc2
[eslint config] [*] [deps] update eslint, eslint-plugin-jsx-a11y. ensure react is >= 13.0.0
2016-05-21 22:11:20 +02:00
Jordan Harband
429339ee37
[eslint config] [*] fix quoting of rule properties.
...
Per #885 .
2016-05-18 20:00:04 -07:00
Jordan Harband
8e125fa07c
[eslint config] [base] [breaking] Enforce proper generator star spacing.
...
Fixes #887 .
2016-05-17 21:27:10 -07:00
Jordan Harband
312cd01a95
[eslint config] [base] quotes: Use object option form rather than deprecated string form.
...
Per https://github.com/airbnb/javascript/pull/886
2016-05-17 13:50:12 -07:00
Joe Lencioni
43ccc3fe11
Enable imports/imports-first rule
...
Since imports are hoisted, keeping them all at the top prevents
surprising behavior.
2016-05-17 09:14:48 -07:00
Jordan Harband
e32079d6c4
Merge pull request #881 from akai/re-order-rules
...
[eslint config] [base] [breaking] Rearrange rules/rule files.
2016-05-16 22:40:38 -05:00
akai
34ccf905d6
[eslint config] [base] [breaking] migrate import's settings/rules to a separate file.
2016-05-17 01:10:00 +08:00
akai
3948eb66d6
[eslint config] [base] [breaking] re-order rules
2016-05-17 00:25:48 +08:00
Jordan Harband
10f4dd88aa
[eslint config] [base] [patch] object-shorthand: do not warn when the concise form would have a string literal as a name.
2016-05-15 21:43:40 -05:00
Jordan Harband
7a8083795d
[eslint config] [base] [patch] Loosen prefer-const to not warn when the variable is “read” before being assigned to.
2016-05-15 21:42:45 -05:00
Jordan Harband
8d6d227848
[eslint config] [*] [tests] Even though the base config may not be up to date in the main package, let’s npm link the base package into the main one for the sake of travis-ci tests.
...
(Followup from c7faa91328
2016-05-15 20:56:54 -05:00
Jordan Harband
638b312b6c
[eslint config] [base] update eslint
2016-05-15 21:14:59 -05:00
Joe Lencioni
4ac8aed126
Prepare to enable react-a11y rules
...
When I first added these, I left TODO notes to come back and evaluate
enabling them. I've gone through and think that we should definitely at
least enable the rules that enforce basic spec compliance (e.g. that
props don't have typos and that all of the required props are provided
for the given role). Since these deal with basic correctness, I don't
think we need to add any verbiage to the style guide for these rules.
We still have some more that we should evaluate and decide about
enabling here, but this is a good step in the right direction.
2016-05-13 11:25:44 -07:00
Jordan Harband
c7faa91328
[eslint config] [tests] Even though the base config may not be up to date in the main package, let’s npm link the base package into the main one for the sake of travis-ci tests.
2016-05-12 17:36:27 -05:00
Jordan Harband
788fb2297a
[eslint config] [*] [deps] update eslint-plugin-import
2016-05-12 17:28:57 -05:00
Joe Lencioni
d68a067f2b
Prepare to enable import/prefer-default-export
...
This was recently added to eslint-plugin-export. It enforces that
modules that only have a single export use a default export instead of a
named export. Since this is a breaking change and we want to cluster
breaking changes, I marked it as 0 for now with a TODO to enable when
that time comes.
2016-05-12 15:21:07 -07:00
Joe Lencioni
5acae06653
Add whitespace between rules
...
I found these rules all smashed together with comments a little
difficult to mentally parse, partly because it is ambiguous which line
the comment applies to. Separating with some whitespace helps a lot
here, and will also reduce the likelihood of merge conflicts in this
code.
2016-05-12 11:43:53 -07:00
Jordan Harband
db732788e7
[eslint config] [react] [patch] loosen jsx-pascal-case rule to allow all caps component names
2016-05-09 15:41:52 -07:00
Jordan Harband
d25a199c56
[eslint config] [deps] update eslint-config-airbnb-base, eslint-plugin-react
2016-05-09 15:40:46 -07:00
Felipe Vargas
b660d4cc3f
Add semicolon in arrow functions section
2016-05-08 18:15:41 -04:00
Jordan Harband
03c5a1f955
[eslint config] v9.0.1
2016-05-08 14:57:25 -07:00
Jordan Harband
d95dc3d500
[eslint config] [base] v3.0.1
2016-05-08 14:55:42 -07:00
Jordan Harband
be5c90a417
[docs] Array.from, not Array#from
2016-05-08 14:54:14 -07:00
Jordan Harband
56a524a47e
[eslint config] [base] [patch] re-disable no-extra-parens
...
Fixes #869 , #867 .
2016-05-08 14:53:24 -07:00
Alejandro Oviedo
ba5d9f0cd7
add links to resources on mdn
2016-05-08 11:33:58 -03:00
Jordan Harband
330169d15e
[eslint config] v9.0.0
2016-05-07 10:39:47 -07:00
Jordan Harband
8b396ab9ef
[eslint config] [deps] Update eslint-config-airbnb-base, eslint-plugin-jsx-a11y, eslint-plugin-import, eslint-find-rules
2016-05-07 10:33:05 -07:00
Jordan Harband
1b31efc07e
[eslint config] [base] v3.0.0
2016-05-06 18:04:54 -07:00
Jordan Harband
92a3d5570b
[eslint config] [base] [breaking] enable import/no-mutable-exports
2016-05-06 17:44:59 -07:00
Jordan Harband
36e088759f
[eslint config] [base] [patch] enable import/no-duplicates
2016-05-06 17:40:57 -07:00
