github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-01-13 23:37:55 -05:00
Code Issues Packages Projects Releases Wiki Activity
340 Commits 5 Branches 102 Tags
2d15deca86ce8fc6aba7614fd42823260c021467
Commit Graph

340 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Harrison Shoff
2d15deca86 Merge pull request #274 from tomekwi/paren-whitespace 
Specify whitespace rules for parentheses
 2015-04-02 09:09:46 -07:00
Tomek Wiszniewski
2e51880f10 Specify whitespace rules for parentheses 
Based on existing examples and <http://sideeffect.kr/popularconvention/#javascript>.
 2015-04-02 04:10:21 +02:00
Harrison Shoff
520b6d658f [resources] add link to standard style by @feross 2015-03-30 13:07:29 -07:00
Harrison Shoff
6c461ff155 Merge pull request #266 from sleeptillseven/master 
Add You Don't Know JS to books
 2015-03-30 09:16:19 -07:00
Christoph Jasinski
b91deedf22 Add You Don't Know JS to books 2015-03-30 00:41:28 +02:00
Josh Perez
adea1d19ab Merge pull request #262 from marcel-me/master 
Add Eloquent JavaScript to books
 2015-03-27 15:58:28 -07:00
marcel-me
716a9658af Add Eloquent JavaScript to books 2015-03-27 22:02:39 +01:00
Harrison Shoff
aad2bf8d02 Merge pull request #260 from joeframbach/patch-1 
String concat code blocks were not equivalent.
 2015-03-27 11:00:59 -07:00
Joe Frambach
3dc4b5edc8 String concat code blocks were not equivalent. 
If the array is empty, the "bad" code will return `<ul></ul>` and the "good" code will return `<ul><li></li></ul>`.

Although I would prefer this over the for loop:

    function inbox(messages) {
      items = messages.map(function(message) {
        return '<li>' + message.message + '</li>';
      });

      return '<ul>' + items.join('') + '</ul>';
 2015-03-27 10:40:15 -07:00
Josh Perez
d8564cfaed Merge pull request #258 from CodeDistillery/master 
Add Nordic Venture Family to organizations list
 2015-03-26 01:30:30 -07:00
Veikko Karsikko
78309e7ddb Add Nordic Venture Family to organizations list 2015-03-26 10:22:35 +02:00
Harrison Shoff
18abccb651 Merge pull request #238 from jigsawye/patch-1 
Update README.md
 2015-03-21 11:22:05 -07:00
Harrison Shoff
114f03539b Merge pull request #250 from vprasanth/master 
Added a book to book list and created Podcasts section
 2015-03-21 11:19:39 -07:00
Harrison Shoff
8368886f5e Merge pull request #253 from T4R-Technology/master 
Added T4R Technology to organizations list
 2015-03-21 11:05:45 -07:00
Bruno Ferreira
7c79b4e21c Added T4R Technology to organizations list 2015-03-20 08:33:35 -03:00
Josh Perez
fa64b975c3 Merge pull request #252 from fvanderwielen/patch-1 
Fixes #251 - Rename Conditional Expressions section
 2015-03-16 15:46:04 -07:00
fvanderwielen
3eef511fd6 Fixes #251 - Rename Conditional Expressions 
As per issue #251, renames section Conditional Expressions & Equality to Comparison Operators & Equality, as the section is not about the Elvis operator :)
 2015-03-16 23:05:09 +01:00
Prasanth Vaaheeswaran
c6191f834b Formatting updated for Podcasts 2015-03-13 13:40:45 -04:00
Prasanth Vaaheeswaran
02d3f52402 Created Podcasts section 2015-03-13 13:39:15 -04:00
Prasanth Vaaheeswaran
5a01165dbb Added a book to the book list 
- Added Effective JavaScript: 68 Specific Ways to Harness the Power of JavaScript
 2015-03-13 13:35:47 -04:00
Spike Brehm
b3e83dcaa5 Merge pull request #249 from justjake/jake/react-style 
If your file exports a single class, your filename should be exactly the name of the class.
 2015-03-11 16:07:05 -07:00
Jake Teton-Landis
e9b573287c naming files containing one class 2015-03-11 15:01:14 -07:00
Harrison Shoff
20cce8f60d Merge pull request #248 from justjake/else 
add `else` to docs
 2015-03-10 20:07:48 -07:00
Jake Teton-Landis
af096c8a94 add else to docs 2015-03-10 16:50:20 -07:00
Harrison Shoff
656a8f6781 [in the wild] add @Jam3 2015-03-03 12:45:16 -08:00
Harrison Shoff
b49d58ff0b [resources] add frontend guidlines by @bendc 2015-02-25 00:28:55 -08:00
Harrison Shoff
60c8972c29 Merge pull request #241 from nimbl3/master 
Adding Nimbl3 to the organizations list
 2015-02-12 09:03:00 -08:00
Harrison Shoff
95eae8840a Merge pull request #242 from omarduarte/patch-1 
(Fix) Add semicolon to whitespace code example
 2015-02-12 09:02:21 -08:00
Omar Duarte
b0a364dedb Missed a semicolon 2015-02-12 00:11:37 -08:00
Carlos Andres Herrera
5406076002 Adding Nimbl3 to the organizations list 2015-02-12 12:23:23 +07:00
Harrison Shoff
b60970a6bf Merge pull request #239 from TheSavior/block-spacing 
Adding comments about spacing between blocks
 2015-02-09 10:56:30 -08:00
Eli White
80e698eb65 Using better examples 2015-02-08 09:39:51 -08:00
Eli White
533e9ea7ba Adding comments about spacing between blocks 2015-02-07 23:35:19 -08:00
Jigsaw
cedfc81848 Update README.md 
Add Chinese(Traditional) to Translation.
 2015-02-04 19:18:48 +08:00
Harrison Shoff
4503923ec5 Merge pull request #234 from apartmint/master 
add Apartmint to list of organizations
 2015-02-01 13:24:58 -08:00
Davy Chiu
384d65e472 add Apartmint to list of organizations 2015-01-31 23:46:58 -05:00
Harrison Shoff
7a9ca5a78a Merge pull request #230 from justjake/no-trailing-dot 
put the dot with fn name when chaining
 2015-01-30 13:30:40 -08:00
Jake Teton-Landis
33363af613 put the dot with fn name when chaining 2015-01-30 13:28:45 -08:00
Harrison Shoff
1e2202938d Merge pull request #232 from ClimbsRocks/patch-2 
Added consistent periods before code snippets, fixing Issue #231
 2015-01-27 19:43:30 -08:00
Preston Parry
233c1db73a Update README.md 2015-01-27 17:48:00 -08:00
Harrison Shoff
9812fdcff3 Merge pull request #229 from ClimbsRocks/patch-1 
Punctuation tweak
 2015-01-22 07:54:49 -08:00
Preston Parry
a280e9595f Punctuation tweak 2015-01-21 23:04:39 -08:00
Harrison Shoff
c729083645 Merge pull request #227 from leomicheloni/master 
Added Kinetica solutions to organizations list
 2015-01-04 19:29:29 -08:00
Leonardo Micheloni
b4c87b1ba9 Added Kinetica solutions to organizations list 2015-01-02 15:20:27 -03:00
Harrison Shoff
d14af4ef24 Merge pull request #224 from gpedro/patch-1 
Brazilian Portuguese Flag
 2014-12-15 17:06:46 -08:00
Gabriel Pedro
7ab3b29463 Brazilian Portuguese Flag 2014-12-15 15:36:12 -03:00
Harrison Shoff
f0781a8971 Merge pull request #220 from justjake/master 
Switch to one-variable-per-var from many-variables-per-var
 2014-12-03 17:54:30 -08:00
Jake Teton-Landis
3c68fc4946 Reformat var change 2014-12-03 17:41:15 -08:00
Jake Teton-Landis
b61d52ca41 use JSDoc/Closure Compiler style type annotations 2014-12-01 14:28:20 -08:00
Jake Teton-Landis
8d51bd504b Switch from single var to one-var-per-variable 
Frontenders at Airbnb at have been discussing this change for a bit, and
we've come to favor one-var-per-variable over one-var-only declarations.
Two things improve the maintainability of this style over one var for
multiple variables:

 1. You never have a diff of a line that's removing a `;` and inserting
    a `,`.
 2. You can't accidentally declare global variables because you have a
    one-character mistake (semicolon instead of comma):

    ```javascript
    var foo = 1,
        bar = 2;
        baz = 3; // added later and (accidentally) declared globally
    ```
 2014-12-01 14:20:22 -08:00