Commit Graph

1615 Commits

Author SHA1 Message Date
Jordan Harband
308fb24815 [eslint config] [*] [deps] update eslint-plugin-import 2018-04-13 13:43:43 -07:00
Jordan Harband
6088a8f5b5 [guide] remove references to jscs 2018-04-12 15:46:55 -07:00
Eray Çetinay
8956338ee9 [guide] Turkish Translation Link Added 2018-04-08 22:51:19 +03:00
Hernaldo Jesus Henriquez
06998522e1 [guide] fix "bad" comment to be actually bad 2018-04-06 14:53:46 -03:00
C. T. Lin
8720f5f90b [eslint config] [base] [patch] avoid __mocks__ no-extraneous-dependencies check 2018-03-28 13:05:12 +08:00
Pramod Garg
bd97fca21b [guide] Minor addition of spaces 2018-04-04 22:45:44 +05:30
Sharmila
c71e8c9231 [eslint config] [base] [breaking] enable import/no-cycle: warn on cyclical dependencies 2018-04-04 16:15:27 -07:00
Sharmila
31d95fded4 [eslint config] [*] [deps] update eslint, eslint-plugin-import, eslint-find-rules 2018-04-04 16:23:02 -07:00
Simon Owen
06e28997b2 Minor spacing update 2018-03-28 15:39:14 +01:00
Jordan Harband
33819d6787 [guide] Added naming conventions for UPPERCASE use cases
Merge pull request #255 from estelle/master
2018-03-23 22:29:20 +00:00
Naomi Jacobs
8ed1d855bb [eslint config] [base] [patch] Include 'accumulator' exception for no-param-reassign 2018-03-20 11:40:04 -07:00
Joe Lencioni
49dab881da Change import/no-self-import from "off" to "error"
We recently had an incident where this rule would have prevented
infinite loops in Hypernova and in the browser.
2018-03-23 08:42:42 -07:00
Shane Mileham
a9f5d519fe Added naming--uppercase section from comment 2018-03-12 11:20:34 -07:00
Remco Haszing
8247e338a2 [eslint config] [base] [patch] Set import/extensions to ignorePackages
This allows to import non-JavaScript files through the main export of a dependency's package.json.

The following would trigger an error before, but is fine with the new configuration:

```js
import 'roboto-fontface';
```
2017-12-04 10:11:35 +01:00
Remco Haszing
a100a3957f [eslint config] [base] [breaking] Update object-curly-newline to match eslint 4.18.0
In eslint v4.18.0 separate settings are introduced for imports and exports for the `object-curly-newline` rule.

Without this change, there is different behavior when updating eslint to this version.
2018-03-01 14:33:02 +01:00
Michael Altamirano
55adae99c9 [guide] Reflect adoption of jest 2018-03-10 17:30:38 -08:00
Rauno
a9fc9d8a0f [docs] [js] add function-paren-newline eslint reference link 2018-03-05 22:24:19 +02:00
Pirasis
396166b1d3 [eslint config] [*] [fix] ensure whitespace entry point is compatible with node 4 2018-03-01 12:15:56 +07:00
Jordan Harband
40dbeace17 [Tests] ensure all entry points parse 2018-02-28 23:00:19 -08:00
Jordan Harband
8e6363c677 [eslint config] [*] [new] add whitespace entry point
Adds eslint config extends with only whitespace rules enabled

Merge pull request #1749 from airbnb/whitespace-rules
2018-02-28 19:01:56 -08:00
Sharmila
6373dab990 Adds config entry point with only whitespace rules enabled
Adds a change to eslint-config-airbnb and eslint-config-airbnb-base to pull a list of rules from the project root and return a config with all rules turned off except the whitespace rules explicitly listed in the array. Also adds entry point data to readme.
2018-02-27 15:21:29 -08:00
Thomas Grainger
c82500d7fa [eslint config] [base] [breaking] enable no-useless-path-segments 2018-02-22 01:07:09 +00:00
Jordan Harband
1fbeabd0c4 [eslint config] [*] [breaking] [deps] update eslint, eslint-plugin-import 2018-02-22 13:51:02 -08:00
Rauno Freiberg
fd68fdbd22 [guide] [react] add comment about what JS standards are followed
Seen a few pull requests for the React style guide that try to introduce features that aren't yet in stage >= 3 (static class fields for i.e), so I've decided to add a comment to the beginning of the guide. Not sure if this is the right place to put it, but here it is.

This disclaimer might help:
1) give the community an idea what standards this guide is based on
2) prevent redundant pull requests
2018-02-20 19:28:52 +02:00
Honza Javorek
ea14bda110 Add licenses to sub packages 2018-02-22 15:48:50 +01:00
Song Xie
a7a7cab504 [guide] Add an anchor for rule 13.7 2018-02-21 14:44:58 -08:00
Jordan Harband
3c3074e502 [eslint config] [*] [deps] update eslint, eslint-find-rules, eslint-plugin-react, tape 2018-02-20 00:10:46 -08:00
Jordan Harband
ff1c12178e [eslint config] [breaking] update eslint-plugin-react to v7.6; update rule configs 2018-01-26 23:31:30 -08:00
Rauno Freiberg
901fd85b7c Use single quotes for consistency 2018-02-19 14:58:24 +02:00
Jordan Harband
cfe10c17d3 fix linting error in guide 2018-02-08 21:45:14 -08:00
Kevin Ji
4c870cbd40 [guide] Fix function signature spacing 2018-02-08 11:29:44 -08:00
Gil Birman
c8b1164105 control-statement--value-selection 2 2018-02-08 13:07:34 -08:00
Ajay Poshak
16190d8cb5 Note added for translation 2018-02-04 18:52:51 +05:30
Teddy Katz
c5411a42d2 Suggest using WeakMaps when hidden properties are needed
This updates the "trailing or leading underscores" guideline to suggest an better way to make properties hidden, as an alternative to just removing the underscore and making the property public.
2018-02-04 17:11:01 -05:00
ParkSB
aefff97bd1 Update Korean translation link 2018-01-30 11:49:24 +09:00
David Clark
9a3e6356cf Added GreenChef organization to README 2018-01-28 00:38:48 -07:00
Ali Oğuzhan Yıldız
17b6491ae2 add Turkish translation 2017-09-04 00:00:04 +03:00
Antonio Erdeljac
1eefaed4fb [guide] [css] Fixed Italic subtitle in css-in-js README.md 2018-01-10 09:08:21 +01:00
Jérémie Astori
fc99aefc4c [guide] Use acc as reduce accumulator instead of memo to make it valid
In [this part of the `no-param-reassign` configuration](53b2d7d245/packages/eslint-config-airbnb-base/rules/best-practices.js (L174-L175)), `acc` is allowed to be mutated (rule [7.12](https://github.com/airbnb/javascript#functions--mutate-params), but `memo` is not.

This causes the [rule 4.6 example](https://github.com/airbnb/javascript#arrays--callback-return) in the README to actually be invalid.
2018-01-26 13:16:39 -05:00
Sharmila
e9fff7adbf [eslint config] [base] [breaking] Prevent line breaks before and after = 2018-01-26 10:57:21 -08:00
Alex Baulch
53b2d7d245 [eslint config] [breaking] bump react pragma to v16; update class-methods-use-this's exceptMethods to include componentDidCatch 2018-01-22 10:42:28 +00:00
zwei
c4dcfd93a7 [guide] fix indentation in section 4.7 2018-01-16 16:20:46 +08:00
Jordan Harband
7dab8371c9 [eslint config] [deps] update eslint 2018-01-20 23:36:32 -08:00
Jordan Harband
7b1ced2bf7 [eslint config] [base] [deps] update eslint 2018-01-20 23:35:21 -08:00
Ben Fortner
262b07b106 fix example to meet standard listingId v listingID
fixed code example to meet the standard. `listingId` changed to `listingID` 
See - Naming Conventions: Acronyms and initialisms should always be all capitalized, or all lowercased.
2018-01-16 09:55:54 -05:00
Aditya Agarwal
a08afd77d5 [eslint-config] [*] [docs] add npx shortcut 2018-01-10 20:04:25 +05:30
Jordan Harband
be647a77fb Merge pull request #1538 from lanceli/patch-1
Change Simplified Chinese translation link
2018-01-09 22:32:15 -08:00
Jordan Harband
69a3554100 [eslint config] [base] [patch] properly ignore indentation on jsx
Fixes #1658.
2018-01-08 00:52:17 -08:00
Jordan Harband
7b18d7c215 [eslint config] [*] [deps] update eslint 2018-01-08 00:35:15 -08:00
Jordan Harband
35f3e76edd Merge pull request #1691 from airbnb/update-mixed-operators-text
[guide] Improves wording of no-mixed-operators recommendation.

Fixes #1678.
2018-01-08 14:57:11 -08:00