Commit Graph

610 Commits

Author SHA1 Message Date
Jordan Harband
5cd011dfa1 [eslint config] [base] [deps] update eslint-plugin-import 2019-04-27 23:51:44 -07:00
Jordan Harband
117d4fce49 [Tests] fix issue with eslint dev deps 2019-04-27 23:27:07 -07:00
Jordan Harband
b85baeafed [eslint config] [base] [meta] add disabled prefer-named-capture-group rule 2019-03-03 23:23:14 -08:00
Jordan Harband
a71c2d1ad3 [eslint config] add disabled jsx-fragments rule 2019-02-17 14:20:53 -08:00
Jordan Harband
834d717c7b [eslint config] [*] [deps] update eslint-plugin-import, eslint-plugin-jsx-a11y, tape 2019-02-17 14:16:48 -08:00
Jamie
8694a87378 [eslint config] [react] [patch] Turn off react/no-multi-comp
Splitting up a component into multiple components can be useful for many reasons, including making important performance optimizations.

This lint rule discourages splitting up components because it forces you to: create a new file, copy over all the relevant imports, move over any local functions/values (or move them into yet another shared module), export the component (which makes your split off component now a public export), and re-import it into the new module.

Having multiple components per file shouldn't be much different from having multiple functions per file. And you shouldn't be forced to make a component a public export if it's really just an internal implementation detail of another component.

There's an argument to be made about _exporting_ multiple components, but mostly just in the context of React.lazy because it can only import default exports and you don't want something else in that file being statically imported (because that will prevent it from being code-split).
2019-02-14 11:57:20 -08:00
Pier-Luc Brault
4f15da6146 [eslint config] [*] [readme] Improve eslint config setup instructions for yarn 2019-02-07 11:48:32 -05:00
tclindner
96f95fa35e [eslint config] [base] [patch] no-extraneous-dependencies: Add jest.setup.js to devDeps 2019-01-29 21:58:23 -06:00
Jordan Harband
25f11fb31e [eslint config] [patch] extend no-underscore-dangle to allow for redux dev tools in the main config instead 2019-01-26 10:12:49 -08:00
Remco Haszing
b6c56cb070 [eslint config] [base] [patch] Allow use of __REDUX_DEVTOOLS_EXTENSION_COMPOSE__
This style guide disallows the use of underscores in properties. However, the
Redux browser extension requires the use of a variable named
`__REDUX_DEVTOOLS_EXTENSION_COMPOSE__`. Since Redux is so popular with React,
it makes sense to allow this.
2019-01-21 13:39:53 +01:00
Jordan Harband
d8256fc886 [eslint config] [*] [deps] update object.entries, eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-react 2019-01-27 13:41:14 -08:00
Jordan Harband
387755e8fe [meta] add disabled no-useless-catch config 2018-12-28 14:31:03 -08:00
Jordan Harband
218c4fefbb [eslint config] [base] [fix] disable no-var in legacy entry point
Fixes #1935.
2018-12-28 13:36:01 -08:00
Ed Morley
21b65e943c [eslint config] [base] [deps] Switch to confusing-browser-globals
The `eslint-restricted-globals` package author created an equivalent
package `confusing-browser-globals` that now resides within the
create-react-app monorepo. In sidoshi/eslint-restricted-globals#2
@sidoshi suggested that we change eslint-config-airbnb-base to depend
on the CRA package instead, in an effort to consolidate the two.

Currently the two global lists are identical, so this does not change
the generated eslint config:
https://unpkg.com/eslint-restricted-globals@0.2.0/index.js
https://unpkg.com/confusing-browser-globals@1.0.5/index.js
2018-11-20 09:40:02 +00:00
Tokyo
32a7bf44c2 ✏️ fix docs for whitespace config 2018-09-12 15:37:59 +01:00
JBallin
17e0454672 [eslint config] [base] [minor] Enforce dangling underscores in method names 2018-09-01 15:48:59 -07:00
Jordan Harband
685f37be39 [eslint config] v17.1.0 2018-08-13 13:39:50 -07:00
Jordan Harband
9a5267684b [eslint config] [patch] re-enabling jsx-one-expression-per-line allowing single children, ignore DOM components on jsx-no-bind; re-enable restructuring-assignment
Reverts b6a268f780
2018-08-13 13:35:23 -07:00
Jordan Harband
152b914935 [eslint config] [deps] update eslint-config-airbnb-base, eslint-plugin-react 2018-08-13 13:31:33 -07:00
Jordan Harband
45326cce63 [eslint-config-airbnb-base] v13.1.0 2018-08-13 00:54:48 -07:00
Jordan Harband
dfb70d6244 [*] [deps] update eslint-plugin-import, safe-publish-latest 2018-08-13 00:51:32 -07:00
Jordan Harband
32a674de0b [eslint config] [*] [deps] update eslint, babel-preset-airbnb, eslint-plugin-jsx-a11y 2018-08-03 21:18:03 -07:00
Jordan Harband
b6a268f780 [eslint config] [react] disable two buggy rules, temporarily 2018-07-09 23:16:25 -07:00
Jordan Harband
a510095acf [eslint config] [*] [new] add eslint v5 support 2018-06-25 15:06:18 -07:00
Jordan Harband
2037fd82b9 [Tests] link eslint from the base config as well 2018-06-25 15:48:07 -07:00
Jordan Harband
7dda84a335 [eslint config] [deps] [minor] update jsx-a11y plugin; enable label-has-associated-control rule
This is semver-minor, because the `label-has-associated-control` rule is
the same as the `label-has-for` rule, theoretically. Both remain
enabled, but `label-has-for` will be disabled in the future if this rule
proves out.
2018-07-04 22:33:27 -07:00
Ahmed Tarek
fe8de59977 [eslint-config] [*] [docs] ✏️ fix typo in Readme 2018-07-03 21:18:11 +02:00
Jordan Harband
27e5e20b70 [eslint config] [base] [new] update base ecmaVersion to 2018; remove deprecated experimentalObjectRestSpread option 2018-06-25 14:14:01 -07:00
Jordan Harband
d951220399 [eslint config] [*] [dev deps] update eslint-find-rules 2018-06-25 13:40:38 -07:00
Jordan Harband
363bb07765 [eslint config] [deps] update eslint-plugin-react 2018-06-24 22:57:06 -07:00
Jordan Harband
8de558b750 [eslint config] [*] [deps] update eslint-plugin-import 2018-06-24 19:41:27 -07:00
Jordan Harband
cae920fc30 [eslint config] v17.0.0 2018-06-21 15:22:10 -07:00
Jordan Harband
d14ed5daa7 [eslint config] [breaking] update eslint-config-airbnb-base 2018-06-21 15:16:52 -07:00
Jordan Harband
afe340773f [eslint config] [base] v13.0.0 2018-06-21 14:46:43 -07:00
Jordan Harband
8be089eb11 [eslint config] fix tests 2018-06-21 14:46:24 -07:00
Jordan Harband
fdb998b38a [eslint config] [base] fix tests 2018-06-21 14:39:07 -07:00
Jordan Harband
951825c6d2 [eslint config] set forbid-foreign-prop-types to "warn" 2018-06-21 14:22:54 -07:00
Gaurav Paliwal
25e711cedd [eslint config] [patch] Add new methods introduced in react@16.3 2018-06-20 17:31:00 +05:30
Moritz Kneilmann
068d6b69bf [eslint config] [base] [patch] Adjust imports for vue-cli
Allows the vue-cli config file `vue.config.js` to import `devDependencies` by altering the rule `import/no-extraneous-dependencies`.
2018-05-15 23:54:09 +02:00
Josh Wells
b3bbd1ccbc [eslint config] [base] [breaking] order of import statements is ignored for unassigned imports 2018-04-11 13:46:34 +01:00
minimooooz
2668495fee add ES2015-2018 in npm package keywords 2017-10-12 11:17:22 +07:00
Jordan Harband
d270031fc0 [eslint config] [*] [dev deps] update babel-preset-airbnb, tape 2018-06-21 13:28:22 -07:00
Jordan Harband
5e260928b6 [eslint config] [react] update eslint-plugin-react 2018-06-03 22:19:41 -07:00
Jordan Harband
04ab225858 [eslint config] [*] [deps] update eslint-plugin-import, eslint-find-rules, eslint-plugin-react 2018-05-27 08:47:29 -07:00
Jimmy Jia
2bd77bc1e0 [eslint config] [base] [patch] label-has-for: Remove redundant component
Also make the rule configuration more explicit.
2018-05-05 22:34:19 -04:00
Thomas Grainger
2d9779907f [eslint config] [base] [minor] only allow one newline at the end 2018-04-30 09:30:38 +01:00
Joe Lencioni
8c83d03a20 [eslint config] [base] [patch] Allow devDependencies for foo_spec.js naming style
Some projects name test files like `foo_spec.js` instead of `foo.spec.js`.
2018-02-15 11:58:17 -08:00
Jordan Harband
fd0834764c [eslint config] [base] fix tests 2018-04-20 15:19:14 -07:00
Jordan Harband
b56875bee2 [eslint config] [base] [patch] function-paren-newline: change to "consistent" 2018-04-20 14:00:50 -07:00
Jordan Harband
308fb24815 [eslint config] [*] [deps] update eslint-plugin-import 2018-04-13 13:43:43 -07:00