Jordan Harband
6f1d92851c
[eslint config] [fix] s/no-case-declaration/no-case-declarations/g (from #712 )
2016-02-03 18:27:59 -08:00
Jordan Harband
b6920af581
[eslint config] [dev deps] update eslint-plugin-react, react, tape
2016-02-03 17:26:33 -08:00
Jordan Harband
7e15ccf4cb
[eslint config] [breaking] disallow unneeded ternary expressions.
2016-02-03 17:25:00 -08:00
Jordan Harband
fa4925be82
Merge pull request #712 from lencioni/no-case-declarations
...
[eslint config] [breaking] Avoid lexical declarations in case/default clauses
2016-02-03 13:04:51 -08:00
Joe Lencioni
4d74fe1f5a
Add example of a case clause that does not need a block
...
As @kesne and @ljharb pointed out, this section was unclear about
whether or not you should always include blocks for all case clauses. To
make things clearer, I am adding a case clause that does not need a
block to the good example.
We decided that we should only require blocks for case clauses that
actually need them because it matches the as-needed spirit of section
3.8 ("Only quote properties that are invalid identifiers"). Perhaps if
there was an as-needed but consistent setting for the ESLint rule, we
would consider revising this a little, but this seems good enough for
now.
2016-02-03 12:23:51 -08:00
Joe Lencioni
38d9b34b27
Avoid lexical declarations in case/default clauses
...
This commit adds guidance warning people to avoid lexical declarations
in case/default clauses and enables the corresponding ESLint rule.
http://eslint.org/docs/rules/no-case-declarations.html
We didn't have a section on switch statements yet, so I thought about
starting one. It seemed like it would best fit between section 15
(Comparison Operators & Equality) and section 16 (Blocks), but I didn't
want to mess up all of the following numberings, since people probably
have references to them. I considered adding this near the end to
minimize this effect, but it really seemed to belong near these other
things. I landed on appending it to Section 15 (Comparison Operators &
Equality) and I think it sorta fits there since switch statements are a
related concept.
2016-02-02 16:11:53 -08:00
Jordan Harband
206e13b185
[guide] remove trailing whitespace
2016-02-02 10:33:18 -08:00
Barry Gitarts
d293e74872
add section 15.5 - Ternaries
...
add link to the relevant eslint rule
2016-02-02 13:11:55 -05:00
Prayag Verma
7eb7b78513
Minor typo
...
Remove extra dot
2016-01-30 10:42:33 +05:30
Mark Sanghoon Kim
51510a43c8
Fixed capitalization and comment spacing
...
Fixed line 1219 to have a lowercase 'a' to be consistent with the style guide.
Fixed line 1831 to only have one space between the // and the =>
2016-01-27 23:14:53 -08:00
Fredrik Olovsson
784d029980
Edit sample code in 24.1 to follow rule 8.1
...
Replaced function expression with arrow function notation.
2016-01-27 11:53:57 +01:00
LarryBattle
79a6bfa101
Added names to invalid function declarations
2016-01-26 23:53:51 -06:00
Ethan Rubio
760e50704c
Fixed capitalization
...
Fixed capitalization of ES6 to match the rest of the README.
2016-01-26 15:09:05 -08:00
Jordan Harband
da1d031ff8
[guide] [react] add a note preferring normal functions for functional stateless components.
2016-01-26 15:03:13 -08:00
Matt Brennan
94776c35eb
Remove language interpretable as an ableist slur
2016-01-26 14:20:55 +00:00
Harrison Shoff
2a7e19a191
Merge pull request #695 from airbnb/move-rules
...
[rule links] reduce visual clutter
2016-01-25 22:40:20 -08:00
Harrison Shoff
7293a0f02d
[rule links] add labels back
2016-01-25 22:34:39 -08:00
Harrison Shoff
992a9cea58
[react][rule links] add eslint labels back
2016-01-25 22:23:16 -08:00
Harrison Shoff
d852f5190e
[react][rule links] condense lines
2016-01-25 22:19:01 -08:00
Harrison Shoff
2c06d87d86
[rule links] reduce visual clutter
2016-01-25 21:46:23 -08:00
Daniel Russell
02e1b4e395
Fixed capitalization
...
Bitshift changed to bitshift
2016-01-24 20:52:24 -08:00
Jordan Harband
c25dbac620
v4.0.0
2016-01-22 16:27:43 -08:00
Harrison Shoff
0839881fd2
Merge pull request #679 from jshen212/patch-1
...
Fix case type on line 3 comment
2016-01-22 09:52:14 -08:00
David Sorrentino
2c9833fbc2
add WeBox Studio to the organizations list
2016-01-22 11:45:56 +01:00
Rick Yeh
fb3c4cac20
Fixed minor capitalization change in Hoisting
...
Not sure if it's an actual fix, but just noticed this was the only comment that had capitalization that wasn't a proper noun
2016-01-21 22:54:27 -08:00
Jordan Harband
06746fa39d
Merge pull request #688 from joaomilho/patch-2
...
[guide] Favor stateless functions over classes when there's no state
2016-01-21 13:17:47 -08:00
Brett Jurgens
36765e4d88
add avant to users
2016-01-20 15:13:31 -06:00
Juan Lulkin
4d2578cc83
Fix PR comments
...
- Space between function name and args;
- use `render(){}` syntax in object literal;
- Fix link to section;
2016-01-20 22:36:11 +02:00
Juan Lulkin
a568c7cf18
Remove space from jsx literal and add space to function definition
...
According to PR comments.
2016-01-20 19:10:20 +02:00
Juan Lulkin
45834dde1c
Favour stateless functions over classes when there's no state
2016-01-20 16:53:59 +02:00
Harrison Shoff
aa6a20e237
Merge pull request #683 from kvzivn/patch-1
...
fix typo
2016-01-19 18:02:42 -08:00
Jordan Harband
fb65b9ae04
[guide] fix a few IIFE examples
2016-01-19 10:15:36 -08:00
Svein Halvor Halvorsen
018dd6e359
arrow-parens
2016-01-19 13:07:37 +01:00
Jordan Harband
586b7d9dfa
[docs] remove trailing whitespace
2016-01-17 18:10:42 -08:00
Kevin Ivan
93a957f4f6
fix typo
2016-01-17 14:55:16 +01:00
Henry Zhu
56ea6c7351
remove specific rule values in text
2016-01-16 22:27:41 -05:00
Henry Zhu
2bd22f0475
Document corresponding jscs rules
2016-01-16 21:46:35 -05:00
Jordan Harband
396e4611c4
[Tests] use parallelshell to parallelize npm run-scripts
2016-01-16 11:02:04 -08:00
Jordan Harband
ab58d3b68e
[Tests] run npm run lint as part of tests; fix errors.
...
hat tip to https://github.com/airbnb/javascript/pull/678#issuecomment-172017623
2016-01-15 10:31:00 -08:00
Prayag Verma
a4845a82cf
Update license year range to 2016
2016-01-16 17:33:50 +05:30
Jeff Shen
c778ade841
Fix case type on line 3 comment
...
Update case type to resemble other comments
2016-01-14 23:30:08 -08:00
Peter Geiss
9498b3f7c4
Clearly show that [] is truthy
2016-01-13 23:12:06 -05:00
Eddie Monge
397f5bbd14
assign variables: give a reason for the assignment
...
The variable assignment wasn't necessary. This gives a reason to have it there
2016-01-13 14:19:14 -08:00
Simon Olofsson
90e6cd1c98
22.3: Add Link to eslint rule.
2016-01-13 17:45:43 +01:00
Jordan Harband
8e47e39fc5
Merge pull request #677 from simono/patch-3
...
[eslint config] [minor] Add `prefer-arrow-callback` to ES6 rules (to match the guide)
2016-01-13 08:36:05 -08:00
Simon Olofsson
54b4dea0f9
Add prefer-arrow-callback to ES6 Rules.
...
This prefers arrow functions as described in https://github.com/airbnb/javascript#8.1
2016-01-13 17:32:30 +01:00
Jordan Harband
44be6af748
Merge pull request #675 from simono/patch-1
...
[guide] 7.3: Add Link to eslint rule.
2016-01-13 08:26:03 -08:00
Simon Olofsson
59a0bccd92
7.3: Add Link to eslint rule.
2016-01-13 12:25:32 +01:00
Jordan Harband
4ef335e242
[eslint config] [breaking] require outer IIFE wrapping; flesh out guide section.
...
There was lots of discussion [here](https://github.com/airbnb/javascript/issues/21#issuecomment-10203921 ), but now that we have both a modern build system and an eslint rule requiring terminating semicolons, the concerns with the “crockford” style no longer apply.
2016-01-10 15:11:05 -08:00
Simon Olofsson
c2fd8fbbd6
Add missing ES6 rules to ESLint config.
...
`arrow-body-style` (8.2) and `prefer-template` (6.4) are described in
the Style Guide.
2016-01-15 10:46:29 +01:00
