Commit Graph

703 Commits

Author SHA1 Message Date
Aleksey Kislov
76ff913d26 Permit strict mode
Permit strict mode for legacy configuration as it is not intended to be used with Babel.
2015-12-23 17:34:31 +03:00
Jordan Harband
eea8efe551 Merge pull request #635 from lencioni/no-is-mounted
[eslint-config] [breaking] Enable react/no-is-mounted rule
2015-12-22 12:07:04 -08:00
Joe Lencioni
f2dc5043a1 [eslint-config] [minor] Enable react/no-is-mounted rule
isMounted is an anti-pattern [0], is not available when using ES6
classes, and is on its way to being officially deprecated.
eslint-plugin-react recently added the react/no-is-mounted rule in
3.12.0 that prevents its use.

[0]: https://facebook.github.io/react/blog/2015/12/16/ismounted-antipattern.html

Finishes #633
2015-12-22 12:04:03 -08:00
Jordan Harband
0af35c9883 Merge pull request #634 from lencioni/sort-prefer-es6-class
[eslint config] Sort react/prefer-es6-class alphabetically
2015-12-22 11:47:34 -08:00
Joe Lencioni
6602586a20 [eslint config] [minor] Sort react/prefer-es6-class alphabetically
All of the other rules in this file are in alphabetical order, but this
one was added by c98990c0f out of order at the end. Keeping these in
alphabetical order will help developers find the rules that they are
looking for.
2015-12-22 11:44:28 -08:00
Jordan Harband
c98990c0f9 [eslint config] [minor] enable react/prefer-es6-class rule 2015-12-22 09:44:26 -08:00
Jordan Harband
c584319df8 [eslint config] [Dev Deps] update eslint-plugin-react 2015-12-22 09:44:07 -08:00
Jordan Harband
88484cec8d Merge pull request #627 from amplii/no-param-reassign-with-props
[eslint config] [breaking] update best-practices config to prevent parameter object manipulation
2015-12-17 11:25:13 -08:00
Thomas Shafer
a533a4fb93 added newlines after each function 2015-12-17 11:18:36 -08:00
Thomas Shafer
f7971301b0 update examples for style
add link to no-param-reassign rule documentation
2015-12-16 20:21:38 -08:00
Thomas Shafer
2589c67b0c update best-practices config to prevent parameter object manipulation
added good/bad examples of parameter mutation to the readme
2015-12-16 15:43:00 -08:00
Jordan Harband
fcc41eecd7 v2.1.1 eslint-config-airbnb-v2.1.1 2015-12-15 13:07:24 -08:00
Jordan Harband
28476a25d8 [eslint config] add rule link and defaults to jsx-quotes rule 2015-12-15 13:06:28 -08:00
Jordan Harband
09bf5e8301 Merge pull request #622 from billyjanitsch/jsx-quotes
[eslint config] [fix] Remove deprecated react/jsx-quotes
2015-12-15 13:03:16 -08:00
Billy Janitsch
bbcb1371e5 Remove deprecated react/jsx-quotes 2015-12-15 15:59:40 -05:00
Jordan Harband
60b01bdfb9 [eslint config] v2.1.0 eslint-config-airbnb-v2.1.0 2015-12-15 01:22:30 -08:00
Jordan Harband
0fc31eaf1c [eslint config] fix b1500397e1 2015-12-15 01:19:32 -08:00
Jordan Harband
4ab41ede1b [eslint config] [Dev Deps] update eslint 2015-12-14 23:55:21 -08:00
Jake Teton-Landis
a7541c9b22 Merge pull request #582 from jkrems/jk-require-resolve
Use require.resolve to allow nested extend
2015-12-14 23:49:00 -08:00
Jordan Harband
b1500397e1 [eslint config] enable object-shorthand rule.
Fixes #621.
2015-12-14 22:21:52 -08:00
Jordan Harband
28a83da1d1 Merge pull request #620 from OutBoxSoft/master
[Docs] Add OutBoxSoft to the list of organizations
2015-12-14 16:21:02 -08:00
Gerardo Renovales
2ab6253f85 Update README.md
Add OutBoxSoft to the list of organizations
2015-12-14 15:06:57 -05:00
Jordan Harband
5989125d2e Merge pull request #618 from kesne/jgens/react-defaults
[eslint config] [react] [minor] Including missing defaults to the react eslint; enable react/jsx-quotes
2015-12-11 23:17:25 -08:00
Jordan Gensler
d02a506377 Adding links to react rules for quick reference. 2015-12-11 23:13:30 -08:00
Jordan Gensler
e9b1ef92bf Adding links to lint rules in react styleguide. 2015-12-11 23:00:10 -08:00
Jordan Gensler
d5a636f298 [react] Including missing defaults to the react eslint 2015-12-11 18:47:48 -08:00
Jordan Harband
8c76e4f486 Merge pull request #617 from frenzzy/patch-1
[eslint config] [breaking] Require space before/after arrow function's arrow (`arrow-spacing`)
2015-12-11 00:55:22 -08:00
Vladimir Kutepov
514bd87d1a Require space before/after arrow function's arrow (arrow-spacing)
Enable [arrow-spacing](http://eslint.org/docs/rules/arrow-spacing.html) rule, code with space before/after arrow function's arrow is easier to read.
```js
() => {};
(a) => {};
a => a;
() => {'\n'};
()=> {};     /*error Missing space before =>*/
() =>{};     /*error Missing space after =>*/
(a)=> {};    /*error Missing space before =>*/
(a) =>{};    /*error Missing space after =>*/
a =>a;       /*error Missing space after =>*/
a=> a;       /*error Missing space before =>*/
()=> {'\n'}; /*error Missing space before =>*/
() =>{'\n'}; /*error Missing space after =>*/
```
2015-12-11 13:50:46 +05:00
Jordan Harband
802725d366 Merge pull request #615 from winterbe/fix15
Fix syntax highlighting in section 15
2015-12-09 01:58:14 -08:00
Benjamin Winterberg
721b8cd01f Fix syntax highlighting in section 15 2015-12-09 10:51:49 +01:00
Josh Perez
6c89f9587f Merge pull request #608 from airbnb/document-eslint-rules
Documents corresponding eslint rules
2015-12-03 15:47:52 -08:00
Josh Perez
a1efff9f6d Documents corresponding eslint rules 2015-12-03 15:39:49 -08:00
Josh Perez
f0fb395714 Merge pull request #607 from JonAbrams/patch-1
Fix example for section 7.11
2015-12-03 14:41:41 -08:00
Jon Abrams
a31c72a1e5 Fix example for section 7.11
The missing newline caused the markdown parser to misinterpret the beginning and end of the code block.
2015-12-03 14:37:52 -08:00
Jordan Harband
4c0a70e435 [eslint config] v2.0.0
- separate changelog
eslint-config-airbnb-v2.0.0
2015-12-03 13:55:09 -08:00
Jordan Harband
326100a7b9 Merge pull request #605 from airbnb/ljharb/fix_function_spacing
[breaking] Require function spacing: `function <optional name>(`
2015-12-03 13:33:45 -08:00
Jordan Harband
2c3b75d256 Merge pull request #606 from airbnb/ljharb/fix_switch_indent
[breaking] Fix switch statement indentation rule
2015-12-03 13:16:51 -08:00
Jordan Harband
4ccd04b69a I abhor switch statements, but their indentation should be:
```js
switch (foo) {
  case 'bar':
    break;
}
```

not what the plugin currently requires:
```js
switch (foo) {
case: 'bar':
  break;
}
```
2015-12-03 00:09:12 -08:00
Jordan Harband
599ca4f123 Require a space between function and (, and function and the function's name, and disallow spaces between the function's name and (. 2015-12-02 22:58:11 -08:00
Jordan Harband
6e6a2b91e1 Merge pull request #604 from Bisk/master
Add Bisk to the list of organizations
2015-12-02 20:58:08 -08:00
Josh Perez
eee4371299 Merge pull request #600 from zwhitchcox/patch-1
Add facebook's react to "In the Wild"
2015-12-02 13:46:57 -08:00
Gerardo Renovales
e754dcc7cf Update README.md
Adding Bisk to the list of organizations
2015-12-02 16:40:41 -05:00
Jordan Harband
b640c952c1 Merge pull request #602 from kesne/jeopardy
Adding jeopardybot to styleguide users.
2015-12-02 12:26:57 -08:00
Jordan Gensler
2944b9b47b Adding jeopardybot to styleguide users. 2015-12-02 12:24:01 -08:00
zwhitchcox
287dee40e5 Add facebook's react to "In the Wild"
I can't believe you guys didn't have that one! That's probably your best one.
2015-12-02 12:48:46 -05:00
Jordan Harband
33e23fb121 Merge pull request #594 from pigoz/parens-brackets-curlys
Make the spaces within parenthesis/brackes/curlys rules explicit
2015-11-30 15:18:50 -08:00
Stefano Pigozzi
6debbcdd73 Add Section 18.11 - Add spaces inside curly braces
Fixes #593
2015-11-28 18:47:46 +01:00
Stefano Pigozzi
ee3759a7ed Add Section 18.10 - No spaces inside brackets
See #593
2015-11-28 13:29:47 +01:00
Stefano Pigozzi
2557a5bca6 Add Section 18.9 - No spaces inside parentheses
See #593
2015-11-28 13:26:37 +01:00
Jake Teton-Landis
e0326137d4 [eslint config] v1.0.2 eslint-config-airbnb-v1.0.2 2015-11-26 15:30:30 -08:00