Jordan Harband
aacaca81c8
Merge pull request #643 from AlicanC/split-never-mutate-parameters
...
[Docs] Make no-param-reassign a separate section.
2015-12-29 09:26:24 -08:00
Alican Çubukçuoğlu
6d9a787ae2
Make reassigning a separate rule.
2015-12-29 19:11:52 +02:00
Jordan Harband
8c241be003
Merge pull request #637 from evenfrost/master
...
[eslint config] Permit strict mode in "legacy" config
2015-12-24 08:35:26 -08:00
Jordan Harband
6d00939747
Merge pull request #639 from chrisngobanh/max-len
...
[eslint config] [breaking] Define a max line length of 100 characters
2015-12-24 08:35:04 -08:00
Christopher Banh
e2e4724fbb
Address comments in #639
...
[eslint] Add comment above `max-len` rule with link to its docs
[eslint] Change tab width for `max-len` rule from 4 to 2
[eslint] Replace double quotes around `max-len` with single quotes
[eslint] Use object form of `max-len` and include all of the options
2015-12-24 02:08:16 -08:00
Christopher Banh
f1c249bcd3
Reword section 6.2 to recognize the line length
2015-12-24 02:08:16 -08:00
Christopher Banh
69d3327362
Enable ESLint rule on limiting maxiumum length of line (max-len)
...
I moved the rule from legacy.js to style.js and enabled it
2015-12-24 02:08:16 -08:00
Christopher Banh
d11f2663c5
Update .jshintrc with new line length
2015-12-24 02:08:16 -08:00
Christopher Banh
b7fbc7b6df
Add section 18.12 on line length
2015-12-24 02:08:16 -08:00
Aleksey Kislov
c9a9194243
Preserve strict rule for default export
2015-12-24 11:31:33 +03:00
Jordan Harband
fbf81eba3a
Merge pull request #581 from tikotzky/update-eslint-react
...
[eslint config] [react] add missing rules from eslint-plugin-react (enforcing where necessary)
2015-12-23 18:56:40 -08:00
Mordy Tikotzky
f2afce75e9
add default config to all rules which take a config
2015-12-23 21:39:31 -05:00
Mordy Tikotzky
b294e7cbf2
add missing rules from eslint-plugin-react
2015-12-23 21:38:53 -05:00
Jordan Harband
fcd1c1d9dc
Merge pull request #619 from kesne/jgens/react-cleanup
...
[eslint config] [breaking] [react] Minor cleanup for the React styleguide
2015-12-23 15:04:00 -08:00
Jordan Gensler
e12e5f0480
Removing name prefix rules.
2015-12-23 14:57:22 -08:00
Jordan Gensler
ae69188304
Removing file extensions. Fixing typos.
2015-12-23 14:57:22 -08:00
Jordan Gensler
5c3137d736
Cleaning up the react styleguide. Adding additional info in props.
2015-12-23 14:57:22 -08:00
Jordan Harband
8815205471
Merge pull request #421 from chrisngobanh/jshintrc-fix
...
Rename jshintrc to .jshintrc
2015-12-23 12:52:54 -08:00
Christopher Banh
8989a8a513
Rename jshintrc to .jshintrc
...
According to http://jshint.com/docs/ , the "special file" to configure JSHint is named `.jshintrc`, not `jshintrc`.
2015-12-23 12:46:03 -08:00
Jordan Harband
75617bd619
Merge pull request #536 from amsardesai/add-version-badge
...
[eslint config] [Docs] Add version badge
2015-12-23 12:17:27 -08:00
Jordan Harband
4adf9303c2
Merge pull request #576 from evolution-gaming/in-the-wild
...
[in the wild] Add Evolution Gaming
2015-12-23 12:12:07 -08:00
Jordan Harband
1ac8baa97c
Merge pull request #636 from lencioni/react-readme-cleanup
...
[Docs] React readme cleanup
2015-12-23 11:44:40 -08:00
Joe Lencioni
474087c426
[readme] Use consistent whitespace in react readme
...
I noticed that some newlines and indentation were a little inconsistent
in this file, so I decided to smooth things out a bit. This should help
people who decide to modify this document in the future. When
determining which is the "right" way to format these things, I decided
to use the style used by base readme as a guide.
2015-12-23 10:12:42 -08:00
Joe Lencioni
a7d3e02a77
[readme] Add missing heading to react TOC
...
I noticed that this heading wasn't listed in the table of contents.
Adding it will help people see at-a-glance what they might find in this
document.
2015-12-23 10:12:42 -08:00
Joe Lencioni
450e64c9d2
[readme] Add backticks around code items in react readme
...
I noticed a number of places in this document where code was being
referenced but it was not marked as such. Adding backticks will instruct
the markdown parser to format these bits as code, which should improve
the readability of this document.
2015-12-23 10:12:42 -08:00
Aleksey Kislov
76ff913d26
Permit strict mode
...
Permit strict mode for legacy configuration as it is not intended to be used with Babel.
2015-12-23 17:34:31 +03:00
Joe Lencioni
055aa14518
[readme] Clean up isMounted section in react readme
...
When I added this section in f2dc5043a
2015-12-22 22:46:25 -08:00
Jordan Harband
eea8efe551
Merge pull request #635 from lencioni/no-is-mounted
...
[eslint-config] [breaking] Enable react/no-is-mounted rule
2015-12-22 12:07:04 -08:00
Joe Lencioni
f2dc5043a1
[eslint-config] [minor] Enable react/no-is-mounted rule
...
isMounted is an anti-pattern [0], is not available when using ES6
classes, and is on its way to being officially deprecated.
eslint-plugin-react recently added the react/no-is-mounted rule in
3.12.0 that prevents its use.
[0]: https://facebook.github.io/react/blog/2015/12/16/ismounted-antipattern.html
Finishes #633
2015-12-22 12:04:03 -08:00
Jordan Harband
0af35c9883
Merge pull request #634 from lencioni/sort-prefer-es6-class
...
[eslint config] Sort react/prefer-es6-class alphabetically
2015-12-22 11:47:34 -08:00
Joe Lencioni
6602586a20
[eslint config] [minor] Sort react/prefer-es6-class alphabetically
...
All of the other rules in this file are in alphabetical order, but this
one was added by c98990c0f
2015-12-22 11:44:28 -08:00
Jordan Harband
c98990c0f9
[eslint config] [minor] enable react/prefer-es6-class rule
2015-12-22 09:44:26 -08:00
Jordan Harband
c584319df8
[eslint config] [Dev Deps] update eslint-plugin-react
2015-12-22 09:44:07 -08:00
Jordan Harband
88484cec8d
Merge pull request #627 from amplii/no-param-reassign-with-props
...
[eslint config] [breaking] update best-practices config to prevent parameter object manipulation
2015-12-17 11:25:13 -08:00
Thomas Shafer
a533a4fb93
added newlines after each function
2015-12-17 11:18:36 -08:00
Thomas Shafer
f7971301b0
update examples for style
...
add link to no-param-reassign rule documentation
2015-12-16 20:21:38 -08:00
Thomas Shafer
2589c67b0c
update best-practices config to prevent parameter object manipulation
...
added good/bad examples of parameter mutation to the readme
2015-12-16 15:43:00 -08:00
Jordan Harband
fcc41eecd7
v2.1.1
2015-12-15 13:07:24 -08:00
Jordan Harband
28476a25d8
[eslint config] add rule link and defaults to jsx-quotes rule
2015-12-15 13:06:28 -08:00
Jordan Harband
09bf5e8301
Merge pull request #622 from billyjanitsch/jsx-quotes
...
[eslint config] [fix] Remove deprecated react/jsx-quotes
2015-12-15 13:03:16 -08:00
Billy Janitsch
bbcb1371e5
Remove deprecated react/jsx-quotes
2015-12-15 15:59:40 -05:00
Jordan Harband
60b01bdfb9
[eslint config] v2.1.0
2015-12-15 01:22:30 -08:00
Jordan Harband
0fc31eaf1c
[eslint config] fix b1500397e1
2015-12-15 01:19:32 -08:00
Jordan Harband
4ab41ede1b
[eslint config] [Dev Deps] update eslint
2015-12-14 23:55:21 -08:00
Jake Teton-Landis
a7541c9b22
Merge pull request #582 from jkrems/jk-require-resolve
...
Use require.resolve to allow nested extend
2015-12-14 23:49:00 -08:00
Jordan Harband
b1500397e1
[eslint config] enable object-shorthand rule.
...
Fixes #621 .
2015-12-14 22:21:52 -08:00
Jordan Harband
28a83da1d1
Merge pull request #620 from OutBoxSoft/master
...
[Docs] Add OutBoxSoft to the list of organizations
2015-12-14 16:21:02 -08:00
Gerardo Renovales
2ab6253f85
Update README.md
...
Add OutBoxSoft to the list of organizations
2015-12-14 15:06:57 -05:00
Jordan Harband
5989125d2e
Merge pull request #618 from kesne/jgens/react-defaults
...
[eslint config] [react] [minor] Including missing defaults to the react eslint; enable react/jsx-quotes
2015-12-11 23:17:25 -08:00
Jordan Gensler
d02a506377
Adding links to react rules for quick reference.
2015-12-11 23:13:30 -08:00
