Commit Graph

1581 Commits

Author SHA1 Message Date
Teddy Katz
c5411a42d2 Suggest using WeakMaps when hidden properties are needed
This updates the "trailing or leading underscores" guideline to suggest an better way to make properties hidden, as an alternative to just removing the underscore and making the property public.
2018-02-04 17:11:01 -05:00
ParkSB
aefff97bd1 Update Korean translation link 2018-01-30 11:49:24 +09:00
David Clark
9a3e6356cf Added GreenChef organization to README 2018-01-28 00:38:48 -07:00
Ali Oğuzhan Yıldız
17b6491ae2 add Turkish translation 2017-09-04 00:00:04 +03:00
Antonio Erdeljac
1eefaed4fb [guide] [css] Fixed Italic subtitle in css-in-js README.md 2018-01-10 09:08:21 +01:00
Jérémie Astori
fc99aefc4c [guide] Use acc as reduce accumulator instead of memo to make it valid
In [this part of the `no-param-reassign` configuration](53b2d7d245/packages/eslint-config-airbnb-base/rules/best-practices.js (L174-L175)), `acc` is allowed to be mutated (rule [7.12](https://github.com/airbnb/javascript#functions--mutate-params), but `memo` is not.

This causes the [rule 4.6 example](https://github.com/airbnb/javascript#arrays--callback-return) in the README to actually be invalid.
2018-01-26 13:16:39 -05:00
Sharmila
e9fff7adbf [eslint config] [base] [breaking] Prevent line breaks before and after = 2018-01-26 10:57:21 -08:00
Alex Baulch
53b2d7d245 [eslint config] [breaking] bump react pragma to v16; update class-methods-use-this's exceptMethods to include componentDidCatch 2018-01-22 10:42:28 +00:00
zwei
c4dcfd93a7 [guide] fix indentation in section 4.7 2018-01-16 16:20:46 +08:00
Jordan Harband
7dab8371c9 [eslint config] [deps] update eslint 2018-01-20 23:36:32 -08:00
Jordan Harband
7b1ced2bf7 [eslint config] [base] [deps] update eslint 2018-01-20 23:35:21 -08:00
Ben Fortner
262b07b106 fix example to meet standard listingId v listingID
fixed code example to meet the standard. `listingId` changed to `listingID` 
See - Naming Conventions: Acronyms and initialisms should always be all capitalized, or all lowercased.
2018-01-16 09:55:54 -05:00
Aditya Agarwal
a08afd77d5 [eslint-config] [*] [docs] add npx shortcut 2018-01-10 20:04:25 +05:30
Jordan Harband
be647a77fb Merge pull request #1538 from lanceli/patch-1
Change Simplified Chinese translation link
2018-01-09 22:32:15 -08:00
Jordan Harband
69a3554100 [eslint config] [base] [patch] properly ignore indentation on jsx
Fixes #1658.
2018-01-08 00:52:17 -08:00
Jordan Harband
7b18d7c215 [eslint config] [*] [deps] update eslint 2018-01-08 00:35:15 -08:00
Jordan Harband
35f3e76edd Merge pull request #1691 from airbnb/update-mixed-operators-text
[guide] Improves wording of no-mixed-operators recommendation.

Fixes #1678.
2018-01-08 14:57:11 -08:00
Sharmila
fe3a2de6b5 [fixes: #1678] Improves wording of no-mixed-operators recommendation. 2018-01-08 14:37:32 -08:00
Jordan Harband
ea8fd76c5e [eslint config] [base] [breaking] Add .mjs extension support
Merge pull request #1635 from olistic/add-mjs-extension-support
2018-01-02 22:52:01 -08:00
Miguel Piedrafita
cb9482c04e [guide] Update license year 2018-01-01 00:50:59 +01:00
Jordan Harband
f9fcb37af1 [guide] Add link to "has" package
Fixes #1670.
2017-12-25 10:37:36 -08:00
Jordan Harband
0991476c9f [guide] Clarify that vars are hoisted to function scope, not block scope
Fixes #1675.
2017-12-25 10:27:33 -08:00
Jordan Harband
1b6bcd0e0f [guide] more precisely refer to an "object literal" instead of just a "hash"
Fixes #1680.
2017-12-25 10:24:54 -08:00
Ronald Eddy Jr
fc34709d19 Docs: HTTP -> HTTPS
URL was updated to use HTTPS protocol
2017-12-24 13:20:12 -08:00
Pirasis
90235cab7c [eslint config] [base] [patch] array-callback-return: enable allowImplicit option 2017-12-24 10:06:09 +07:00
Jordan Harband
9061044af0 [eslint config] [*] [deps] update eslint, eslint-plugin-jsx-a11y 2017-12-23 20:25:29 -08:00
Thomas Broadley
8a12ffed19 [guide] Fix spelling error in link
(preserve old link for back-compat)
2017-12-15 20:31:09 -05:00
Ilici
255b0f369a Fix third example in Enclosed operators section 2017-12-14 23:14:27 +01:00
Kristóf Poduszló
4817a6b75c [eslint config] [patch] Add 'to' as a specialLink to the 'anchor-is-valid' a11y rule
Support React Router's `<Link to="...">` attribute out of the box.
2017-11-28 19:47:00 +01:00
Jordan Harband
b709023494 [eslint config] [base] [breaking] enable implicit-arrow-linebreak 2017-11-29 23:52:45 -08:00
Jordan Harband
2087a42b51 [eslint config] [base] [deps] update eslint 2017-11-29 23:43:55 -08:00
Matias Olivera
eb50272401 Forbid .mjs extension from being specified 2017-11-05 13:23:21 -03:00
Matias Olivera
1d9d25d278 Add .mjs to the list of supported extensions 2017-11-05 13:21:48 -03:00
Josh Bourgeois
8cf2c70a41 [guide] Add explanation for semicolon enforcement rule
Also update code samples to highlight ways in which ES6
currently mishandles code when relying on Automatic Semicolon
Insertion

Revise hyperlink and example

- Use more up-to-date TC39 reference page on github.io
- wrap returnless function with side-effects in curly braces

also, clean up punctuation on a long comment line

Always use single-quoted strings

Except for when the string needs to be double-quoted because the string contains apostrophes

Update second example to incorporate IIFE

An IIFE is a more realistic example of code that developers may encounter which would raise an exception when relying completely upon ASI
2017-10-04 13:38:13 -07:00
Jordan Harband
44dbd0bdc4 [eslint config] [patch] disable no-did-mount-set-state, since it’s necessary for server-rendering.
Fixes #684.
2017-11-04 01:02:09 -07:00
Maggie Love
5682155e9a Adds section about spreading props 2017-11-01 18:33:54 -04:00
Jordan Harband
1948c302fd [Tests] on node v9; use nvm install-latest-npm so new npm doesn’t break old node; pin included builds to LTS. 2017-11-01 08:01:50 -07:00
Ed Morley
7ff6303513 [guide] Use HTTPS for links to ESLint documentation
The result of a `s_http://eslint\.org_https://eslint\.org_g`.
Avoids the HTTP 302s of the non-HTTPs URLs.
2017-10-30 13:19:22 +00:00
Jordan Harband
2d4343acd1 [guide] remove/update outdated links.
Fixes #1626.
2017-10-27 22:10:32 -07:00
Vse Mozhet Byt
c40d0d1f84 [guide] Fix a link, add an anchor 2017-10-28 03:41:29 +03:00
Jordan Harband
9edcdde8fe Merge pull request #1620 from lasota-piotr/classname-props
[guide] [react] Added anti-pattern example for Props Naming rule, changed className props in examples
2017-10-25 13:33:52 -07:00
Pirasis Leelatanon
dbdf8ea0ef [doc] add eslint rule reference for no-multi-assign 2017-10-26 02:21:23 +07:00
Pirasis Leelatanon
327795bf3c [doc] add eslint rule reference for no-new-wrappers 2017-10-26 02:36:13 +07:00
Piotr Lasota
9d3e7e0a2c Add component with className as anti-pattern example 2017-10-25 20:05:40 +02:00
Piotr Lasota
999fe3b83a Change className to variant in examples 2017-10-25 20:03:56 +02:00
Sharmila
2676cbfb2f [eslint config] [base] [breaking] Enables nonblock-statement-body-position rule and adds link to guide 2017-10-24 17:49:14 -07:00
Jordan Harband
8a477f9893 Merge pull request #1616 from leonidlebedev/patch-1
Remove unnecessary variables
2017-10-24 13:27:03 -07:00
Leonid Lebedev
ecf8e077a7 Remove unnecessary variables 2017-10-24 14:33:47 +03:00
Arnav
bd3ba6edfe Add symbol as a primitive type
- Also add note that symbols cannot by polyfilled and should not be used in environments that don't support them
2017-10-23 15:04:58 -07:00
Vse Mozhet Byt
dbd69346bd [guide] Fix a numeration typo in README.md
- also remove legacy numbered link
2017-10-24 00:07:05 +03:00