github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-01-14 15:37:55 -05:00
Code Issues Packages Projects Releases Wiki Activity
393 Commits 5 Branches 102 Tags
cb47b478c70bb0d1bee0a60643c5970bd67a799a
Commit Graph

393 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Josh Perez
cb47b478c7 Amend grammar for default parameters 2015-04-28 21:28:05 -07:00
Herrington Darkholme
d0028724ea add semicolons 2015-04-28 21:28:05 -07:00
Matias Singers
e5006931f1 Use modules in naming conventions example 
Following the rule from further up: "Always use modules (import/export) over a non-standard module system."
 2015-04-28 21:28:05 -07:00
Tomek Wiszniewski
0cca5e21fc Fix hoisting examples 
Hoisting only happens to `var`. As kangax describes in [Why `typeof` is no longer “safe”](http://es-discourse.com/t/why-typeof-is-no-longer-safe/15/3).

Also, I wonder if we need the whole section, since you recommend to [avoid using `var` altogether](https://github.com/airbnb/javascript/blob/b492/README.md#references).
 2015-04-28 21:28:05 -07:00
dsc
ee176044c3 Rename two let keywords to const 2015-04-28 21:28:05 -07:00
Tomek Wiszniewski
875d2ad05e Add esnext to the jsHint configuration 
This way we'll allow ES6 syntax.
 2015-04-28 21:28:05 -07:00
Harrison Shoff
f7321b303d [modules] fix invalid syntax in bad example. fixes #287 2015-04-28 21:28:05 -07:00
Harrison Shoff
6d34c516cc [toc] remove extra modules link 2015-04-28 21:28:05 -07:00
Sean Massa
38ae6b6df2 add bad comment to bad section of destructuring 2015-04-28 21:28:05 -07:00
NoNameSheep
e826067498 advice against side effect in default parameter 2015-04-28 21:28:05 -07:00
Luke Westby
bc5b0ee007 Change wording in Iterators and Generators 
I found the term "function constructors" to be confusing as the functions the section refers to are not constructors. I think "higher-order functions" or something similar would be more clear.

Thanks!
 2015-04-28 21:28:05 -07:00
Josh Perez
22e3c89d04 Removing a few trailing commas 2015-04-28 21:28:05 -07:00
Josh Perez
a6a573e3cc Use more template literals, s/suffer/blessed with 2015-04-28 21:28:04 -07:00
Casey Jenks
b8fd0438fb Iterators and Generators: sum should be 15, not 10 2015-04-28 21:27:44 -07:00
Josh Perez
58cdc731f4 Initial ES6 style guide 2015-04-28 21:27:44 -07:00
Harrison Shoff
b50a43d2ad Merge pull request #324 from nkt/patch-1 
Allow dot-notation keywords in eslint
 2015-04-28 10:30:22 -07:00
Josh Perez
8d0f04c492 Merge pull request #322 from kzsh/clarifying-enforced-rule 
Clarifying what rule is being enforced.
 2015-04-27 17:43:30 -07:00
Andrew
a6e906a1b9 Clarifying what rule is being enforced. 
Capitalization of constructors is not the rule in question here.  It makes it more clear what the offending difference is between `//bad` and `//good` to have consistent constructor capitalization.
 2015-04-27 20:18:32 -04:00
Josh Perez
1282ee63df Add comment on why we're breaking a rule 2015-04-27 16:39:57 -07:00
Nikita Gusakov
15c947b48b Allow dot-notation keywords in eslint 
ES6 gives us promises, which have `.catch` method. Other Promise implementation also uses `try` and `finally` methods, which are also reserved keywords ([bluebird](https://github.com/petkaantonov/bluebird/blob/master/API.md)).
 2015-04-25 18:24:58 +03:00
Josh Perez
0c6697104b Merge pull request #321 from JSSolutions/master 
Added new organization.
 2015-04-23 12:59:11 -07:00
Maxim
a1b53a1d85 Added new organization. 2015-04-23 15:25:49 +03:00
Josh Perez
92d9cbdf5d Merge pull request #318 from jensechu/master 
Remove excess whitespace in Whitespace section
 2015-04-20 16:57:11 -07:00
Jensen
17dde0d593 Remove excess whitespace in Whitespace section 2015-04-20 16:17:48 -07:00
Harrison Shoff
6de02b80a2 Merge pull request #316 from airbnb/eslintrc 
[linters] update .eslintrc. fixes: #313, #259
 2015-04-19 19:31:24 -07:00
Harrison Shoff
dc100c8d31 Merge pull request #317 from airbnb/fix-var-example 
[variables] fix variable hoisting example. fixes #265
 2015-04-19 17:55:03 -07:00
Harrison Shoff
7fe4883a75 [variables] fix variable hoisting example. fixes #265 2015-04-19 15:42:15 -07:00
Harrison Shoff
91d56b6874 [eslint] fix whitespace, silence underscore dangle 2015-04-19 15:34:51 -07:00
Harrison Shoff
b694fedccd [linters] update .eslintrc 2015-04-18 17:58:26 -07:00
Harrison Shoff
10ef68a4ab Merge pull request #315 from sinkswim/master 
Added italian translation
 2015-04-18 11:41:37 -07:00
robertmargelli
5fe373c646 Added italian translation 2015-04-17 15:13:59 -07:00
Josh Perez
c496b7e840 Merge pull request #314 from Flexberry/master 
Add Flexberry to the organizations list
 2015-04-17 08:28:46 -07:00
nagits
64013fb578 Add Flexberry to the organizations list 2015-04-17 18:28:05 +05:00
Harrison Shoff
56f2aad65a Merge pull request #312 from lvarayut/patch-1 
Add Thai language version
 2015-04-15 21:20:33 -07:00
Varayut Lerdkanlayanawat
67dda213b8 Add Thai language version 2015-04-16 10:12:06 +07:00
Harrison Shoff
b893ce0daf Merge pull request #272 from RobLoach/eslint 
Add ESLint support
 2015-04-08 10:53:56 -07:00
Harrison Shoff
d5cddf836c Merge pull request #292 from sunshinewyin/master 
Fix minor punctuation errors in README
 2015-04-08 10:52:36 -07:00
Harrison Shoff
ddbc7aa0fd Merge pull request #295 from airbnb/fix-whitespace-ex 
[whitespace] class => classed. fixes #294
 2015-04-06 18:02:06 -07:00
Harrison Shoff
540365c4cc [whitespace] class => classed. fixes #294 2015-04-06 18:00:36 -07:00
Josh Perez
0501155c5e Merge pull request #283 from marcioos/master 
Rephrasing Array#push style guide
 2015-04-05 21:05:51 -07:00
Josh Perez
7ed9511a2f Merge pull request #288 from RKushnir/master 
Fix a typo in selector
 2015-04-05 21:05:41 -07:00
Josh Perez
e2688acf30 Merge pull request #293 from honzi/honzi-patch-1 
Alphabetized Translation links
 2015-04-05 21:03:36 -07:00
Rob Loach
87ea8909d8 fix(one-var): Add one-var setting from @nkbt 2015-04-05 23:04:13 -04:00
Jan Hořava
999a9f3dc5 Alphabetized Translation links 2015-04-05 14:51:18 -07:00
Sunshine Yin
6cda67e2f5 Fix minor punctuation errors 
(1) BEFORE: Never name a parameter `arguments`, this will take precedence over the `arguments` object.
AFTER: Never name a parameter `arguments`. This will take precedence over the `arguments` object.

(2) BEFORE: Variable declarations get hoisted to the top of their scope, their assignment does not.
AFTER:
Variable declarations get hoisted to the top of their scope, but their assignment does not.

(3) BEFORE: for multiline comments
AFTER: for multi-line comments

(4)BEFORE: It’s okay to write a custom toString() method, just make sure
AFTER: It's okay to write a custom toString() method. Just make sure
 2015-04-05 12:57:01 -07:00
Roman
ebe8cb253d Fix a typo in selector 2015-04-04 11:47:48 +03:00
Marcio Oliveira
4b012cddf3 Rephrasing Array#push style guide 2015-04-03 19:51:16 -03:00
Josh Perez
483bc27a7c Merge pull request #277 from adult-swim/airbnb 
Added Adult Swim to In the Wild section
 2015-04-02 12:46:31 -07:00
Justin Gardner
2bccaf6203 Added Adult Swim to In the Wild section 2015-04-02 20:40:40 +01:00
Rob Loach
3058e38d01 fix(eslint): Remove amd and jquery from env 2015-04-02 12:36:42 -04:00