Jordan Harband
da0cf08831
[Tests] on node v11
2019-02-17 14:21:15 -08:00
Jordan Harband
a71c2d1ad3
[eslint config] add disabled jsx-fragments rule
2019-02-17 14:20:53 -08:00
Jordan Harband
834d717c7b
[eslint config] [*] [deps] update eslint-plugin-import, eslint-plugin-jsx-a11y, tape
2019-02-17 14:16:48 -08:00
Jamie
8694a87378
[eslint config] [react] [patch] Turn off react/no-multi-comp
...
Splitting up a component into multiple components can be useful for many reasons, including making important performance optimizations.
This lint rule discourages splitting up components because it forces you to: create a new file, copy over all the relevant imports, move over any local functions/values (or move them into yet another shared module), export the component (which makes your split off component now a public export), and re-import it into the new module.
Having multiple components per file shouldn't be much different from having multiple functions per file. And you shouldn't be forced to make a component a public export if it's really just an internal implementation detail of another component.
There's an argument to be made about _exporting_ multiple components, but mostly just in the context of React.lazy because it can only import default exports and you don't want something else in that file being statically imported (because that will prevent it from being code-split).
2019-02-14 11:57:20 -08:00
Pier-Luc Brault
4f15da6146
[eslint config] [*] [readme] Improve eslint config setup instructions for yarn
2019-02-07 11:48:32 -05:00
Zeeshan Ahmad
6ef45d4bab
[guide] make "good" example match "bad" example more closely
2019-02-06 14:09:18 +04:00
tclindner
96f95fa35e
[eslint config] [base] [patch] no-extraneous-dependencies: Add jest.setup.js to devDeps
2019-01-29 21:58:23 -06:00
Sharmila Jesupaul
ebe96824e2
Merge branch 'master' into translation-proposal
2019-02-05 11:51:09 -08:00
Jordan Harband
d78af39118
Merge pull request #1996 from remcohaszing/redux-devtools-extension-compose
...
[eslint config] [base] [patch] Allow use of `__REDUX_DEVTOOLS_EXTENSION_COMPOSE__`
2019-01-27 21:21:48 -08:00
Jordan Harband
d8256fc886
[eslint config] [*] [deps] update object.entries, eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-react
2019-01-27 13:41:14 -08:00
Jordan Harband
25f11fb31e
[eslint config] [patch] extend no-underscore-dangle to allow for redux dev tools in the main config instead
2019-01-26 10:12:49 -08:00
Telmen Munkhdalai
1439ebe78d
[editorial] [react] fix typo
2019-01-26 16:55:34 +08:00
Remco Haszing
b6c56cb070
[eslint config] [base] [patch] Allow use of __REDUX_DEVTOOLS_EXTENSION_COMPOSE__
...
This style guide disallows the use of underscores in properties. However, the
Redux browser extension requires the use of a variable named
`__REDUX_DEVTOOLS_EXTENSION_COMPOSE__`. Since Redux is so popular with React,
it makes sense to allow this.
2019-01-21 13:39:53 +01:00
Hoang
955f4e93b8
Vietnamese translation
2019-01-13 18:55:49 +07:00
Rahil Vora
95286eb496
[guide] [react] add note about forbid-prop-types rule
2019-01-07 10:24:16 -06:00
Jordan Harband
070e6200bb
[Dev Deps] update markdownlint-cli
2018-12-28 14:32:02 -08:00
Jordan Harband
387755e8fe
[meta] add disabled no-useless-catch config
2018-12-28 14:31:03 -08:00
Jordan Harband
218c4fefbb
[eslint config] [base] [fix] disable no-var in legacy entry point
...
Fixes #1935 .
2018-12-28 13:36:01 -08:00
Emily Rohrbough
80920a07c5
Add Terra to README list
2018-12-19 13:06:08 -06:00
Honza Javorek
5d25a2ee61
capitalize means first letter uppercase, the rest lowercase
...
The examples and the reasoning indicates the author of the rule meant uppercase instead of capitalization. According to Wikipedia, capitalization is "writing a word with its first letter as a capital letter (uppercase letter) and the remaining letters in lower case", while the rule apparently tries to prevent exactly that.
2018-12-18 16:11:26 +01:00
Michael Käfer
064e3bf8d5
:) conflicting with rule 8.2 :D
2018-11-27 20:51:21 +01:00
Kevin Weber
ffe4fe967c
[guide] Clarify wording
2018-08-25 22:12:12 -07:00
ernestodebesto
69e34378c6
Examples more consistent with the guidline
...
comparison operator <= shows better the confusion when using arrow function, than just operator <
2018-09-14 17:20:22 +02:00
NullDev (Chris)
6ece1f58e9
Added NullDev
...
because why not
2018-11-21 10:51:20 +01:00
NullDev (Chris)
0d6d854b5c
[17.2] Added second anchor https://github.com/airbnb/javascript/pull/1960
...
See requested changes here: https://github.com/airbnb/javascript/pull/1960#pullrequestreview-176797787
2018-11-21 10:48:35 +01:00
Ed Morley
21b65e943c
[eslint config] [base] [deps] Switch to confusing-browser-globals
...
The `eslint-restricted-globals` package author created an equivalent
package `confusing-browser-globals` that now resides within the
create-react-app monorepo. In sidoshi/eslint-restricted-globals#2
@sidoshi suggested that we change eslint-config-airbnb-base to depend
on the CRA package instead, in an effort to consolidate the two.
Currently the two global lists are identical, so this does not change
the generated eslint config:
https://unpkg.com/eslint-restricted-globals@0.2.0/index.js
https://unpkg.com/confusing-browser-globals@1.0.5/index.js
2018-11-20 09:40:02 +00:00
KY3LxD
74deb81d1f
[editorial] Improve conciseness of README.md
2018-11-12 23:38:19 -08:00
Bikram Sutar
41a13e83ee
[19.16] changed Enforce to avoid
...
Good practice is to avoid spaces between functions and their invocations. But by mistake (I think so) you used the word Enforce instead of Avoid
2018-10-30 15:05:16 +05:30
Martín Anzorena
03a0734fce
Add UrbanSim to organizations list
2018-10-17 01:51:06 +08:00
Pirasis Leelatanon
24da5bb540
[doc] add eslint rule references in react guide
...
* react/jsx-filename-extension
* react/no-array-index-key
2018-10-04 20:29:10 +07:00
Pirasis Leelatanon
924dfb2682
[doc] add eslint rule reference for no-prototype-builtins
2018-10-03 23:56:48 +07:00
Parul Gupta
9af5ee89eb
Updated wording of variable--one-const rule
2018-10-02 16:26:25 +05:30
Tokyo
32a7bf44c2
✏️ fix docs for whitespace config
2018-09-12 15:37:59 +01:00
侯林江
02b4eea345
[guide] update to a better Chinese translation
2017-01-19 18:21:22 +08:00
Siddharth Batra
e7ffd44b4a
Update .markdownlint.json
...
Fixed typos and grammar
2018-09-02 22:59:40 +05:30
JBallin
17e0454672
[eslint config] [base] [minor] Enforce dangling underscores in method names
2018-09-01 15:48:59 -07:00
Robert Alvarez
b8b2a0b0e0
Add Pier1 to the organization list
2018-08-31 15:10:43 -05:00
Kevin Weber
48448a81cc
[guide] [react] Explain use of ID over key right on page
2018-08-26 17:41:01 -07:00
Kevin Weber
5443d03de2
[guide] Consistently use curly quotes instead of straight quotes in prose
2018-08-26 17:50:48 -07:00
Kevin Weber
fcfd378dd8
Fix outdated link to Airbnb's Neutrino preset
2018-08-25 22:54:31 -07:00
Jordan Harband
d774b8979e
Merge pull request #1898 from kevinweber/react/props--unnecessary-props
...
List bad example first to be consistent
2018-08-26 22:21:05 -07:00
Kevin Weber
ced1cb3ad8
List bad example first to be consistent
2018-08-26 17:15:08 -07:00
Jordan Harband
685f37be39
[eslint config] v17.1.0
2018-08-13 13:39:50 -07:00
Jordan Harband
9a5267684b
[eslint config] [patch] re-enabling jsx-one-expression-per-line allowing single children, ignore DOM components on jsx-no-bind; re-enable restructuring-assignment
...
Reverts b6a268f780
2018-08-13 13:35:23 -07:00
Jordan Harband
152b914935
[eslint config] [deps] update eslint-config-airbnb-base, eslint-plugin-react
2018-08-13 13:31:33 -07:00
Jordan Harband
45326cce63
[eslint-config-airbnb-base] v13.1.0
2018-08-13 00:54:48 -07:00
Jordan Harband
dfb70d6244
[*] [deps] update eslint-plugin-import, safe-publish-latest
2018-08-13 00:51:32 -07:00
Jordan Harband
32a674de0b
[eslint config] [*] [deps] update eslint, babel-preset-airbnb, eslint-plugin-jsx-a11y
2018-08-03 21:18:03 -07:00
Andrew Scheuermann
a12dec90d1
[guide] [react] boolean in jsx alignment
2018-07-11 16:26:22 -07:00
Jordan Harband
b6a268f780
[eslint config] [react] disable two buggy rules, temporarily
2018-07-09 23:16:25 -07:00
