Commit Graph

660 Commits

Author SHA1 Message Date
Gerardo Renovales
e754dcc7cf Update README.md
Adding Bisk to the list of organizations
2015-12-02 16:40:41 -05:00
Jordan Harband
b640c952c1 Merge pull request #602 from kesne/jeopardy
Adding jeopardybot to styleguide users.
2015-12-02 12:26:57 -08:00
Jordan Gensler
2944b9b47b Adding jeopardybot to styleguide users. 2015-12-02 12:24:01 -08:00
Jordan Harband
33e23fb121 Merge pull request #594 from pigoz/parens-brackets-curlys
Make the spaces within parenthesis/brackes/curlys rules explicit
2015-11-30 15:18:50 -08:00
Stefano Pigozzi
6debbcdd73 Add Section 18.11 - Add spaces inside curly braces
Fixes #593
2015-11-28 18:47:46 +01:00
Stefano Pigozzi
ee3759a7ed Add Section 18.10 - No spaces inside brackets
See #593
2015-11-28 13:29:47 +01:00
Stefano Pigozzi
2557a5bca6 Add Section 18.9 - No spaces inside parentheses
See #593
2015-11-28 13:26:37 +01:00
Jake Teton-Landis
e0326137d4 [eslint config] v1.0.2 eslint-config-airbnb-v1.0.2 2015-11-26 15:30:30 -08:00
Jordan Harband
7476c31246 Merge pull request #592 from ariporad/patch-1
[rules: es6] enable restParams
2015-11-26 00:55:51 -06:00
Ari Porad
e424a249e3 Enable rest params! 2015-11-25 20:48:48 -08:00
Josh Perez
639e3c709a Merge pull request #584 from jonathanp/master
Avoid the word "mutate" while explaining `const`
2015-11-17 11:58:17 -08:00
jpersson
a3495e07f4 Avoid the word "mutate" while explaining const 2015-11-17 13:12:02 -05:00
Jake Teton-Landis
60480c05ea Merge pull request #578 from adrienverge/enforce-rule-18.5
[eslint] Enforce rule 18.5
2015-11-11 10:57:24 -08:00
Adrien Vergé
09c8589e44 [eslint] Enforce rule 18.5
Rule 18.5 [1] states that files shall end with a single newline
character. Until now, this was not checked because there was no such
option in eslint.

Since version 1.8.0, eslint provides the ability to do that. See pull
request on eslint [2] for details on implementation and usage. Let's use
it in airbnb eslint plugin now!

[1]: https://github.com/airbnb/javascript#18.5
[2]: https://github.com/eslint/eslint/pull/4266
2015-11-11 10:27:04 -08:00
Jordan Harband
87c9507bb5 Merge pull request #572 from joscha/patch-1
docs: babel-eslint not neede since 1.0.0 any more
2015-11-08 21:36:10 -08:00
Joscha Feth
aa6ca6ff68 docs: babel-eslint not neede since 1.0.0 any more 2015-11-09 14:44:17 +11:00
Jordan Harband
d9b5585be4 [eslint config] v1.0.0 eslint-config-airbnb-v1.0.0 2015-11-08 11:12:17 -08:00
Jordan Harband
c0ef4540e5 Merge pull request #570 from airbnb/ljharb/update_eslint
[eslint config] update `eslint` to require 1.0 or greater
2015-11-06 16:36:21 -08:00
Jordan Harband
d432f58655 Add eslint as a peer dep, 1.0 or greater 2015-11-06 16:32:28 -08:00
Jordan Harband
0b7c979d82 [eslint] Remove babel-eslint dependency. 2015-11-06 15:16:49 -08:00
Jordan Harband
88603b8445 [eslint] update eslint, eslint-plugin-react, react, tape. 2015-11-06 13:09:34 -08:00
Jake Teton-Landis
f4e5967a0a Merge pull request #547 from chrisngobanh/padded-blocks
Prohibit Padded Blocks and Allow Comments in the First Line of a Block
2015-11-05 16:45:47 -08:00
Jake Teton-Landis
7b0ff1246e eslint-config-airbnb 0.1.1 eslint-config-airbnb-v0.1.1 2015-11-05 15:36:01 -08:00
Jake Teton-Landis
c5d3a3434c Merge pull request #569 from airbnb/jake/remove-id-length-rule
[eslint] remove id length rule (too much nutrage)
2015-11-05 15:35:20 -08:00
Jake Teton-Landis
06ed38d57f [eslint] remove id length rule (too much nutrage) 2015-11-05 15:18:59 -08:00
Harrison Shoff
8514f74322 Merge pull request #551 from majapw/patch-1
`export default` should not be inline with the class declaration
2015-11-04 11:17:53 +01:00
Harrison Shoff
a4e5858a35 Merge pull request #566 from airbnb/fix-stray-eval
[6.5] add backticks around stray eval. fixes #556
2015-11-04 11:13:56 +01:00
Harrison Shoff
f130c0ffa2 [6.5] add backticks around stray eval. fixes #556 2015-11-04 11:12:45 +01:00
Harrison Shoff
88d5084009 Merge pull request #564 from frankenbot/master
Update redirects
2015-11-04 11:07:13 +01:00
Jordan Harband
bbeb6a0d38 Merge pull request #562 from airbnb/ljharb/testing
Start to write a realistic "testing" section
2015-11-02 23:33:30 -08:00
frankenbot
49293bbf8c Update redirects 2015-11-02 20:11:56 -08:00
Jordan Harband
f2f8186d0f Start to write a realistic "testing" section 2015-10-31 13:49:53 -07:00
Jordan Harband
2c172bbe3b Merge pull request #561 from adrienverge/issue-539
eslint: Enforce `no-mixed-spaces-and-tabs`
2015-10-30 10:49:53 -07:00
Adrien Vergé
7b834b989c eslint: Fix no-mixed-spaces-and-tabs turn off
Currently the way the rule is defined, mixing spaces and tabulations in
indentation is allowed. However, the comments and documents seems to say
the opposite.

This patchs turns the rule on so mixing spaces and tabs is NOT allowed.

Fixes: #539
2015-10-30 17:00:14 +01:00
Jordan Harband
893ffb34fe Merge pull request #560 from rhbecker/update-eslint-config_no-const-assign
disallow reassignment of `const` variables
2015-10-29 22:48:46 -07:00
RH Becker
b056ad09bb Flag modification of variables that are declared using const keyword as an error. 2015-10-29 22:43:33 -07:00
Jake Teton-Landis
01ba082cf3 Merge pull request #554 from adrienverge/space-before-keywords
eslint: Add missing `space-before-keywords` rule
2015-10-23 09:11:47 -07:00
Adrien Vergé
ab0a6ca92b eslint: Add missing space-before-keywords rule
All examples in README.md seem to agree on avoiding missing whitespaces
before keywords such as:

    if (cond) {
    }else {       // no space before 'else'
    }

    try {
    }catch (e) {  // no space before 'catch'
    }

This patchs adds the `space-before-keywords` rule as an error (as is
`space-after-keywords` already).
2015-10-23 10:57:24 +02:00
Maja Wichrowska
efe7507e65 export default should not be inline with the class declaration
When there are static variables like `propTypes` and `defaultProps`, we shouldn't export them until we have actually set them onto the `Component`. This may change if the current ES7 proposal for static class properties gets accepts, and we update to support it.
2015-10-20 17:31:01 -07:00
Christopher Banh
4b5348a5fc Add examples with if statements to 18.8 2015-10-16 10:35:14 -07:00
Christopher Banh
d276b0c389 Update 17.2 to allow comments in the first line of a block
In #483, justjake said that we should update the style guide to allow
single line comments in the first line of a block.
2015-10-15 18:15:54 -07:00
Christopher Banh
9897e7d8d1 Add Section 18.8 - No padded blocks
This addresses #483
2015-10-15 18:10:25 -07:00
Jake Teton-Landis
89d1e07882 Merge pull request #544 from HubSpot/in-the-wild
Add HubSpot to 'In The Wild' section
2015-10-13 21:31:28 -07:00
Nick Hwang
8dd0b758f3 Add HubSpot to 'In The Wild' section 2015-10-13 23:21:02 -04:00
Josh Perez
8d6a1b40aa Merge pull request #534 from cooperka/react-quote-reasoning
Add reasoning for using double quotes in JSX
2015-10-05 15:41:04 -07:00
Kevin Cooper
ef7fbea3d9 Add further reasoning for using double quotes in JSX 2015-10-01 16:53:49 -07:00
Kevin Cooper
d4f69efeec Add reasoning for using double quotes in JSX 2015-10-01 15:11:17 -07:00
Harrison Shoff
f823047e46 Merge pull request #533 from ecosia/update-inthewild
Add Ecosia to "In the Wild" section.
2015-10-01 10:14:02 -07:00
Gregory McCue
3c3c9a299d Fix link text. 2015-10-01 19:08:05 +02:00
Gregory McCue
be61bbd53c Add Ecosia to "In the Wild" section. 2015-10-01 11:35:30 +02:00