Commit Graph

562 Commits

Author SHA1 Message Date
Jake Teton-Landis
fde9c12719 Merge pull request #479 from justjake/jake/some-small-issues
Modularize eslintrc, add tests
2015-08-19 14:10:12 -07:00
Jake Teton-Landis
2d90ebf11b update README with new package structure 2015-08-19 14:01:14 -07:00
Jake Teton-Landis
7646a8619b lint eslint-config-airbnb with eslint-config-airbnb/base 2015-08-19 14:00:53 -07:00
Jake Teton-Landis
048e22ea98 somewhat modularize eslint-config-airbnb; add some tests 2015-08-18 18:02:31 -07:00
Jordan Harband
425e1f9cb9 Merge pull request #478 from tayre/typo_fix
s/Javascript/JavaScript
2015-08-18 12:23:04 -07:00
Tom
6175c67a79 s/Javascript/JavaScript 2015-08-18 14:54:29 -04:00
Jake Teton-Landis
d2be5f3c74 Merge pull request #446 from tschuy/master
change second 18.5 to 18.6
2015-08-18 11:25:30 -07:00
Jake Teton-Landis
67c0f0ea7d Merge pull request #475 from airbnb/react_export_prop_types
Recommend exporting `propTypes` as a named export
2015-08-18 11:22:16 -07:00
Jake Teton-Landis
2c26413b61 Merge pull request #461 from slava-sh/patch-1
Put `everything-else` before `render`
2015-08-18 10:38:30 -07:00
Slava Shklyaev
0068cc1d6e Put custom component methods before render methods 2015-08-18 20:14:24 +03:00
Jordan Harband
c4fdbc2742 Recommend exporting propTypes as a named export
By exporting `propTypes` as a named export *as well* as attaching them to the "class", they can be explicitly imported by tests and other components in a way that aligns with the future ES6 module dependency graph, rather than as an arbitrary property that isn't statically verifiable. Doing both is great imo.

Thoughts?
2015-08-17 20:42:58 -07:00
Jake Teton-Landis
909fc8b5d7 Merge pull request #463 from nkt/feature/simplify-eslint-config
Simplify ESLint config package.
2015-08-14 17:44:20 -07:00
Harrison Shoff
fff3d6d48d Merge pull request #472 from tomekwi/implicit-return-#438
Implicit return + single expression
2015-08-13 09:44:17 -07:00
Tomek Wiszniewski
bfbb074ac9 Oops, keep to 13.1! 2015-08-13 08:51:04 +02:00
Tomek Wiszniewski
417f9896d0 Bring back explicit return in 8.1 example 2015-08-13 08:48:21 +02:00
Tomek Wiszniewski
60360bdedd Match 8.4 indentation to other rules 2015-08-13 08:43:59 +02:00
Tomek Wiszniewski
3aabe2c693 Upgrade half of 8.2 to another rule 2015-08-13 08:43:33 +02:00
Tomek Wiszniewski
5b8b56ece7 Upgrade a note about parens to another rule 2015-08-12 11:17:19 +02:00
Tomek Wiszniewski
5634c4c88e Update existing example 2015-08-12 11:14:53 +02:00
Tomek Wiszniewski
4957071107 Allow implicit return + one multiline expression 2015-08-12 11:14:51 +02:00
Harrison Shoff
9e40dd1001 Merge pull request #471 from comparaonline/add-comparaonline
Add ComparaOnline to 'In The Wild' List
2015-08-11 13:43:09 -07:00
Choon-ho Yoon
52a3344043 Add ComparaOnline to 'In The Wild' List 2015-08-11 17:27:02 -03:00
Josh Perez
6b1239b0c9 Merge pull request #467 from chrisngobanh/master
Updated 25.1 to include a case with a lookup that has a hyphen in the classname
2015-08-10 11:29:36 -07:00
Jordan Harband
ce0ce5eac3 Merge pull request #468 from udivankin/patch-1
deleted unnecessary whitespace after property key
2015-08-10 11:11:41 -07:00
allx
1e2ed0b069 Update README.md
deleted unnecessary whitespace after property key
2015-08-10 14:26:43 +03:00
Christopher Banh
e8b87a5e21 Updated 25.1 to include a case with a hyphen in the classname 2015-08-09 20:30:41 -07:00
Nikita Gusakov
20b6913202 Simplify ESLint config package.
This patch moves `.eslintrc` contents into `index.js` directly.
This allows us to drop external dependencies and using javascript
comments instead of not valid JSON.
2015-08-08 17:46:56 +03:00
Josh Perez
cac2d2848d Merge pull request #459 from airbnb/goatslacker-patch-1
Amendments section to encourage forking
2015-08-06 20:41:19 -07:00
Josh Perez
d455d6af9e Amendments section to encourage forking
Amendments alter what the style guide says but can be contained in a single section thus allowing you to periodically update or cherry pick from the style guide from master without having to deal with annoying merge conflicts.
2015-08-06 13:01:40 -07:00
Harrison Shoff
0d3a649404 Merge pull request #455 from tomekwi/patch-5
Mention eslint-config-airbnb
2015-08-05 11:49:54 -07:00
Tomek Wiszniewski
d874a94a0a Mention eslint-config-airbnb
Actually, if we want to make the thing more convenient, we could go as far as saying: “

Before using our `.eslintrc` install these dependencies:

```sh
npm install --save-dev eslint-config-airbnb eslint babel-eslint eslint-plugin-react
```

”. I want to leave the decision up to you though.
2015-08-05 19:45:08 +02:00
Harrison Shoff
220696b9df Merge pull request #453 from airbnb/harry-add-badge
[readme] add downloads badge
2015-08-04 10:00:33 -07:00
Harrison Shoff
d4e64139f5 [readme] add downloads badge 2015-08-04 09:59:28 -07:00
Harrison Shoff
21295b0c98 Merge pull request #452 from springload/add-springload
Add Springload to "In the Wild" list
2015-08-03 08:24:54 -07:00
Thibaud Colas
b3357f5b88 Add Springload to "In the Wild" list
Springload loves the Airbnb style guide!
2015-08-03 22:39:23 +12:00
Jake Teton-Landis
ea093e0373 Merge pull request #449 from justjake/jake/spaced-comment-lenient
[eslint] allow +, -, =, ! in comments without a space
eslint-config-airbnb-v0.0.7
2015-07-30 17:57:00 -07:00
Jake Teton-Landis
ff4dc46d05 [eslint] allow +, -, =, ! in comments without a space 2015-07-30 17:49:47 -07:00
Jake Teton-Landis
26194e282f Merge pull request #448 from justjake/jake/packages
[eslint] restructure eslint-config-airbnb, move .eslintrc
2015-07-30 17:40:55 -07:00
Jake Teton-Landis
dbbf71bd71 eslintrc extends eslint-config-airbnb 2015-07-30 15:08:47 -07:00
Jake Teton-Landis
cf5266bc52 [eslint] document dependences in README 2015-07-30 15:01:17 -07:00
Jake Teton-Landis
a45dfe359b [eslint] remove peerDependencies 2015-07-30 14:59:19 -07:00
Jake Teton-Landis
abc85310b9 [eslint] add readme to eslint-config-airbnb 2015-07-30 14:49:34 -07:00
Jake Teton-Landis
f5cac3cc5c [eslint] remove most dependencies 2015-07-30 14:48:32 -07:00
Jake Teton-Landis
2f55be7cc3 [eslint] move .eslintrc into packages/eslint-config-airbnb 2015-07-30 14:47:42 -07:00
Jake Teton-Landis
1b212cf5b9 Merge pull request #431 from pascalduez/pr__update_eslint_config
Update ESlint deprecated rules
2015-07-30 14:12:39 -07:00
Evan Tschuy
d2db3b6290 change duplicate 18.5 to 18.6 2015-07-30 10:06:53 -07:00
Harrison Shoff
0c29596a7e Merge pull request #395 from Ryan-McBride/patch-1
Update to include warning against using eval.
2015-07-29 11:45:30 -07:00
Harrison Shoff
4070463927 Merge pull request #404 from airbnb/harry/100-char
[strings] 80 char => 100 char
2015-07-29 11:41:04 -07:00
Harrison Shoff
fa1fd87c53 Merge pull request #442 from tomekwi/fix-eslintrc
Get rid of `no-reserved-keys` in the .eslintrc
2015-07-29 11:33:25 -07:00
Tomek Wiszniewski
3c260d8e8a Get rid of no-reserved-keys in the .eslintrc
After all [point 8.2](https://github.com/airbnb/javascript/tree/63bece1#3.2) allows them in an ES 2015+ environment.
2015-07-29 20:32:19 +02:00