Commit Graph

6418 Commits

Author SHA1 Message Date
Parker Moore
378ec5a4b8 Merge pull request #4311 from jekyll/use-drop-hash-accessor
Merge pull request 4311
2016-01-04 13:04:14 -08:00
Jordon Bedwell
e10c483ec3 Adjust Rubocop to fit in a bit better. 2016-01-04 14:44:13 -06:00
Parker Moore
2756503e7b features/hooks: use hash syntax to access page 2016-01-04 12:37:19 -08:00
Parker Moore
735194ccaf Convertible/Page/Renderer: use payload hash accessor & setter syntax 2016-01-04 12:37:19 -08:00
Parker Moore
87978e79f4 features/step_definitions: use $stderr instead of STDERR
Fixes c273d91df1 (commitcomment-15251676)
2016-01-04 12:36:05 -08:00
Parker Moore
eaade1e49a Update history to reflect merge of #4301
[ci skip]
2016-01-04 12:32:15 -08:00
Parker Moore
5580972282 Merge pull request #4301 from pathawks/rubocop
Merge pull request 4301
2016-01-04 12:31:55 -08:00
Pat Hawks
060904d809 Rubocop: Style/TrailingWhitespace
- Trailing whitespace detected
Rubocop: Style/EmptyLines
 - Extra blank line detected
Rubocop: Style/EmptyLinesAroundBlockBody
 - Extra empty line detected at block body beginning
2016-01-04 12:16:36 -08:00
Pat Hawks
ab3d906e04 Rubocop: Style/ParenthesesAroundCondition
- Don't use parentheses around the condition of an if
2016-01-04 12:14:00 -08:00
Pat Hawks
cce848d3d8 Rubocop: Avoid single-line method definitions 2016-01-04 12:12:17 -08:00
Parker Moore
c273d91df1 cucumber: fix issue where an undefined step would cause an exception 2016-01-04 12:08:02 -08:00
Pat Hawks
c1c8b6dbf7 Rubocop: Style/SpaceInsideHashLiteralBraces 2016-01-04 12:07:34 -08:00
Pat Hawks
04e635b10c Rubocop: Style/SpaceInsideRangeLiteral
- Space inside range literal
2016-01-04 12:06:40 -08:00
Pat Hawks
6711234d5f Rubocop: Style/BlockDelimiters
- Avoid using {...} for multi-line blocks
2016-01-04 12:05:54 -08:00
Pat Hawks
086e85ca9e Rubocop: Style/PerlBackrefs
- Avoid the use of Perl-style backrefs
2016-01-04 12:01:23 -08:00
Pat Hawks
be3666fcf0 Rubocop: Do not use unless with else
- Rewrite these with the positive case first
2016-01-04 11:51:14 -08:00
Pat Hawks
ec83ef60b5 Rubocop: Lint/UselessAssignment 2016-01-04 11:49:54 -08:00
Pat Hawks
085a778b0a Rubocop: Style/NestedTernaryOperator
- Ternary operators must not be nested. Prefer if/else constructs instead.
2016-01-04 11:46:25 -08:00
Pat Hawks
78e9f3389e Rubocop: Style/IndentationWidth 2016-01-04 11:42:17 -08:00
Pat Hawks
f9926edbc4 Rubocop: Style/TrivialAccessors
- Use `attr_writer` to define trivial writer methods
2016-01-04 11:39:14 -08:00
Pat Hawks
af9ec6831d Rubocop: Style/ElseAlignment
- Align else with if
Rubocop: Lint/EndAlignment
 - Align end with if
2016-01-04 11:23:06 -08:00
Parker Moore
c4047c37b2 Update history to reflect merge of #4303
[ci skip]
2016-01-04 11:16:05 -08:00
Pat Hawks
f6fd9014ba Rubocop: Style/CaseIndentation
- Indent when as deep as case
2016-01-04 11:15:37 -08:00
Parker Moore
046928e395 upgrading docs: add note about removing relative permalinks support (2 to 3)
Ref: #4303.
2016-01-04 11:15:16 -08:00
Parker Moore
c38e1fcbb8 Merge pull request #4303 from alistaircom/patch-1
Added content on relative permalinks
2016-01-04 11:14:56 -08:00
Pat Hawks
2c9a349f9a Rubocop: Style/Next
- Use next to skip iteration
2016-01-04 11:10:52 -08:00
Pat Hawks
f221b925b4 Rubocop: Lint/StringConversionInInterpolation
- Redundant use of Object#to_s in interpolation
2016-01-04 11:08:31 -08:00
Pat Hawks
13c980c896 Rubocop: Style/TrailingComma 2016-01-04 11:08:31 -08:00
Pat Hawks
4c5d77a4b5 Rubocop: Style/EmptyLines 2016-01-04 11:08:18 -08:00
Parker Moore
224a1ab9ef Merge pull request #4305 from Atul9/master
Update copyright notices to 2016 [ci skip]
2016-01-03 21:50:18 -08:00
Pat Hawks
fd8fdd87d3 Rubocop: Style/RegexpLiteral 2016-01-03 17:10:39 -08:00
Pat Hawks
e3189e3828 Rubocop: Lint/UnusedMethodArgument 2016-01-03 17:07:39 -08:00
Pat Hawks
11f0aab4b1 Rubocop: Lint/UnusedBlockArgument
- Unused block argument
2016-01-03 16:24:13 -08:00
Pat Hawks
7ca4f7cd62 Rubocop: Style/Proc
- Use proc instead of Proc.new
...and use lambda instead of proc
2016-01-03 16:18:26 -08:00
Pat Hawks
af5d51289f Rubocop: Style/SymbolProc
- Pass &:to_sym as an argument to map instead of a block
 - Pass &:capitalize as an argument to select instead of a block
 - Pass &:to_s as an argument to map instead of a block
2016-01-03 16:02:32 -08:00
Pat Hawks
704ca6b8cc Rubocop: Style/NegatedIf
- Favor unless over if for negative conditions
2016-01-03 15:59:12 -08:00
Pat Hawks
663a2d3279 Rubocop: Style/SpaceBeforeBlockBraces
Rubocop: Style/SpaceInsideBlockBraces
2016-01-03 15:58:02 -08:00
Pat Hawks
a70d89a862 Rubocop: Style/SpaceAfterComma
- Space missing after comma
2016-01-03 15:56:44 -08:00
Pat Hawks
cda226de45 Rubocop: Style/EmptyLinesAroundClassBody
- Extra empty line detected at class body end
2016-01-03 15:55:33 -08:00
Pat Hawks
2530a8cdfc Rubocop: Style/HashSyntax
- Use hash rockets syntax
2016-01-03 15:49:22 -08:00
Pat Hawks
d157a04c6d Rubocop: Performance/StringReplacement
- Use delete! instead of gsub!
 - Use tr instead of gsub
2016-01-03 15:47:31 -08:00
Pat Hawks
ff5f7b7120 Rubocop: Style/DeprecatedHashMethods
- Hash#has_key? is deprecated in favor of Hash#key?
Add method `key?` to Drop
2016-01-03 15:41:04 -08:00
Pat Hawks
98a19cdf2b Rubocop: Style/PercentLiteralDelimiters
- %w-literals should be delimited by ( and )
Rubocop: Style/WordArray
 - Use %w or %W for array of words
2016-01-03 15:32:11 -08:00
Pat Hawks
fb0457bf3d Rubocop: Style/AndOr
- Use && instead of and
 - Use || instead of or
2016-01-03 15:30:26 -08:00
Pat Hawks
6550867051 Rubocop: Style/SpecialGlobalVars
- Prefer $LOAD_PATH over $:
2016-01-03 15:29:49 -08:00
Pat Hawks
8223ebd861 Use select and find instead of conditional loop 2016-01-03 15:24:18 -08:00
Pat Hawks
0eae36aec2 Rubocop: Style/LineEndConcatenation
- Use \ instead of + or << to concatenate those strings
2016-01-03 14:41:49 -08:00
Pat Hawks
44d2995277 Rubocop: Style/Semicolon
- Do not use semicolons to terminate expressions
2016-01-03 14:40:45 -08:00
Pat Hawks
31dd0ebed5 Rubocop: Style/EmptyLiteral
- Use array literal [] instead of Array.new
 - Use hash literal {} instead of Hash.new
2016-01-03 14:39:01 -08:00
Jordon Bedwell
ffdbeb89dd Further refine our Rubocop to the current styles. 2016-01-03 15:57:47 -06:00