Commit Graph

6393 Commits

Author SHA1 Message Date
Pat Hawks
f9926edbc4 Rubocop: Style/TrivialAccessors
- Use `attr_writer` to define trivial writer methods
2016-01-04 11:39:14 -08:00
Pat Hawks
af9ec6831d Rubocop: Style/ElseAlignment
- Align else with if
Rubocop: Lint/EndAlignment
 - Align end with if
2016-01-04 11:23:06 -08:00
Pat Hawks
f6fd9014ba Rubocop: Style/CaseIndentation
- Indent when as deep as case
2016-01-04 11:15:37 -08:00
Pat Hawks
2c9a349f9a Rubocop: Style/Next
- Use next to skip iteration
2016-01-04 11:10:52 -08:00
Pat Hawks
f221b925b4 Rubocop: Lint/StringConversionInInterpolation
- Redundant use of Object#to_s in interpolation
2016-01-04 11:08:31 -08:00
Pat Hawks
13c980c896 Rubocop: Style/TrailingComma 2016-01-04 11:08:31 -08:00
Pat Hawks
4c5d77a4b5 Rubocop: Style/EmptyLines 2016-01-04 11:08:18 -08:00
Pat Hawks
fd8fdd87d3 Rubocop: Style/RegexpLiteral 2016-01-03 17:10:39 -08:00
Pat Hawks
e3189e3828 Rubocop: Lint/UnusedMethodArgument 2016-01-03 17:07:39 -08:00
Pat Hawks
11f0aab4b1 Rubocop: Lint/UnusedBlockArgument
- Unused block argument
2016-01-03 16:24:13 -08:00
Pat Hawks
7ca4f7cd62 Rubocop: Style/Proc
- Use proc instead of Proc.new
...and use lambda instead of proc
2016-01-03 16:18:26 -08:00
Pat Hawks
af5d51289f Rubocop: Style/SymbolProc
- Pass &:to_sym as an argument to map instead of a block
 - Pass &:capitalize as an argument to select instead of a block
 - Pass &:to_s as an argument to map instead of a block
2016-01-03 16:02:32 -08:00
Pat Hawks
704ca6b8cc Rubocop: Style/NegatedIf
- Favor unless over if for negative conditions
2016-01-03 15:59:12 -08:00
Pat Hawks
663a2d3279 Rubocop: Style/SpaceBeforeBlockBraces
Rubocop: Style/SpaceInsideBlockBraces
2016-01-03 15:58:02 -08:00
Pat Hawks
a70d89a862 Rubocop: Style/SpaceAfterComma
- Space missing after comma
2016-01-03 15:56:44 -08:00
Pat Hawks
cda226de45 Rubocop: Style/EmptyLinesAroundClassBody
- Extra empty line detected at class body end
2016-01-03 15:55:33 -08:00
Pat Hawks
2530a8cdfc Rubocop: Style/HashSyntax
- Use hash rockets syntax
2016-01-03 15:49:22 -08:00
Pat Hawks
d157a04c6d Rubocop: Performance/StringReplacement
- Use delete! instead of gsub!
 - Use tr instead of gsub
2016-01-03 15:47:31 -08:00
Pat Hawks
ff5f7b7120 Rubocop: Style/DeprecatedHashMethods
- Hash#has_key? is deprecated in favor of Hash#key?
Add method `key?` to Drop
2016-01-03 15:41:04 -08:00
Pat Hawks
98a19cdf2b Rubocop: Style/PercentLiteralDelimiters
- %w-literals should be delimited by ( and )
Rubocop: Style/WordArray
 - Use %w or %W for array of words
2016-01-03 15:32:11 -08:00
Pat Hawks
fb0457bf3d Rubocop: Style/AndOr
- Use && instead of and
 - Use || instead of or
2016-01-03 15:30:26 -08:00
Pat Hawks
6550867051 Rubocop: Style/SpecialGlobalVars
- Prefer $LOAD_PATH over $:
2016-01-03 15:29:49 -08:00
Pat Hawks
8223ebd861 Use select and find instead of conditional loop 2016-01-03 15:24:18 -08:00
Pat Hawks
0eae36aec2 Rubocop: Style/LineEndConcatenation
- Use \ instead of + or << to concatenate those strings
2016-01-03 14:41:49 -08:00
Pat Hawks
44d2995277 Rubocop: Style/Semicolon
- Do not use semicolons to terminate expressions
2016-01-03 14:40:45 -08:00
Pat Hawks
31dd0ebed5 Rubocop: Style/EmptyLiteral
- Use array literal [] instead of Array.new
 - Use hash literal {} instead of Hash.new
2016-01-03 14:39:01 -08:00
Jordon Bedwell
ffdbeb89dd Further refine our Rubocop to the current styles. 2016-01-03 15:57:47 -06:00
Jordon Bedwell
b7d5a26d53 Move around CodeClimate so people can do bundle exec rubocop.
/cc @pathawks -- This is why you were not getting the custom settings we had
made and some things were showing up as broken when they weren't.  Sorry.
2016-01-03 02:21:21 -06:00
Jordon Bedwell
a2623be3da Be consistent with your hashes and arrays.
```
val = %W(hello world
                 world)
```

```
var = %W(
  hello
  world
)
```

```
var = %W(hello world)
```
2016-01-03 00:15:31 -06:00
Jordon Bedwell
2a280b7f62 Reduce our surface, extend self is useful for some modules.
We should handle extend self and module_function on a case-by-case basis because there
are times when extend self is useful, especially when you wish a module to be included but also
available on itself.  `module_function` does not allow this.
2016-01-02 23:58:59 -06:00
Alfred Xing
519c0f1b38 Update history to reflect merge of #4293
[ci skip]
2015-12-30 10:43:01 -08:00
Alfred Xing
f5fe4b89bd Merge pull request #4293 from alfredxing/incremental-docs
Merge pull request 4293
2015-12-30 10:42:34 -08:00
Parker Moore
a1c97c66fb Update history to reflect merge of #4299
[ci skip]
2015-12-30 09:26:18 -08:00
Parker Moore
fdffc8aaaa Merge pull request #4299 from pathawks/jekyll-commonmark
Merge pull request 4299
2015-12-30 09:24:43 -08:00
Pat Hawks
bf4bfcf4f0 Add link to jekyll-commonmark 2015-12-29 18:02:59 -08:00
Alfred Xing
e98f543513 Add some documentation for incremental regeneration 2015-12-27 19:45:16 -08:00
Jordon Bedwell
e048e428d1 Update History.markdown 2015-12-27 12:56:42 -06:00
Jordon Bedwell
43618c90c7 Merge pull request #4292 from jekyll/pull/fix-liquid-drop-requires
Move require "jekyll/drops/drop" to "jekyll.rb"

Linux does not read files in alphanumeric order, this can lead to
Jekyll drops not working on Linux because the assumption here is that
the collection drop will be required first.
2015-12-27 12:55:51 -06:00
Jordon Bedwell
f2f88dbd9f Move require "jekyll/drops/drop" to "jekyll.rb"
Linux does not read files in alphanumeric order, this can lead to
Jekyll drops not working on Linux because the assumption here is that
the collection drop will be required first.
2015-12-27 12:48:21 -06:00
Parker Moore
5034216637 Release 💎 3.1.0.pre.beta1 v3.1.0.pre.beta1 2015-12-27 08:32:08 -05:00
Parker Moore
cb342c375d Update history to reflect merge of #4289
[ci skip]
2015-12-27 08:27:37 -05:00
Parker Moore
7c4876d2eb Merge pull request #4289 from jekyll/fix-utils-deep-merge-drops
Merge pull request 4289
2015-12-27 08:27:25 -05:00
Parker Moore
e302873203 Update history to reflect merge of #3771
[ci skip]
2015-12-27 08:25:29 -05:00
Parker Moore
1b73751abf Merge branch 'fixup-custom-markdown'
* fixup-custom-markdown:
  markdown: minor style fixes
  Add support for underscores.
  Refactor: lib/jekyll/convertor/markdown.rb - tests: no additions/breaks.
2015-12-27 08:24:16 -05:00
Parker Moore
8e887dcd8b markdown: minor style fixes
ref: #3771
2015-12-27 08:24:00 -05:00
Parker Moore
5bf596b239 utils/drops: update Drop to support Utils.deep_merge_hashes
Fixes #4287
2015-12-27 08:06:37 -05:00
Pat Hawks
69a6323599 Utils.deep_merge_hashes failing test 2015-12-27 07:48:45 -05:00
Parker Moore
59a5fc64f9 Update history to reflect merge of #4281
[ci skip]
2015-12-26 22:09:34 -05:00
Parker Moore
1bc3f63db7 Merge pull request #4281 from jekyll/drop-to_h
Merge pull request 4281
2015-12-26 22:09:14 -05:00
Parker Moore
fe690a8377 Merge pull request #4288 from pathawks/calling-setter
Wrap Arguments in () when used in a setter
2015-12-26 19:03:54 -05:00