github/jquery-ui
1
1
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2026-02-05 09:35:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Dialog: Fixed #3688: Don't add the button pane div if there are no buttons.

Browse Source
This commit is contained in:
Scott González
2009-01-17 21:31:43 +00:00
parent 60856ea461
commit c2903d5c42
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
ui/ui.dialog.js
View File

@@ -126,15 +126,7 @@ $.widget("ui.dialog", {
.addClass('ui-dialog-title')
.attr('id', titleId)
.html(title)
.prependTo(uiDialogTitlebar),
uiDialogButtonPane = (this.uiDialogButtonPane = $('<div></div>'))
.addClass(
'ui-dialog-buttonpane ' +
'ui-widget-content ' +
'ui-helper-clearfix'
)
.appendTo(uiDialog);
.prependTo(uiDialogTitlebar);
uiDialogTitlebar.find("*").add(uiDialogTitlebar).disableSelection();
@@ -256,14 +248,19 @@ $.widget("ui.dialog", {
_createButtons: function(buttons) {
var self = this,
hasButtons = false,
uiDialogButtonPane = this.uiDialogButtonPane;
uiDialogButtonPane = $('<div></div>')
.addClass(
'ui-dialog-buttonpane ' +
'ui-widget-content ' +
'ui-helper-clearfix'
);
// remove any existing buttons
uiDialogButtonPane.empty().hide();
// if we already have a button pane, remove it
this.uiDialog.find('.ui-dialog-buttonpane').remove();
$.each(buttons, function() { return !(hasButtons = true); });
(typeof buttons == 'object' && buttons !== null &&
$.each(buttons, function() { return !(hasButtons = true); }));
if (hasButtons) {
uiDialogButtonPane.show();
$.each(buttons, function(name, fn) {
$('<button type="button"></button>')
.addClass(
@@ -288,6 +285,7 @@ $.widget("ui.dialog", {
})
.appendTo(uiDialogButtonPane);
});
uiDialogButtonPane.appendTo(this.uiDialog);
}
},