github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-02-01 17:14:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Improve jsonp tests

Browse Source 
Since global variable for callback always would be equal to undefined value
it better to check for boolean instead
This commit is contained in:
Oleg Gaidarenko
2014-02-18 21:50:42 +04:00
parent 9cdaa75b86
commit 1c04178939
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/data/testrunner.js
View File

@@ -196,7 +196,7 @@ window.Globals = (function() {
return {
register: function( name ) {
globals[ name ] = true;
supportjQuery.globalEval( "var " + name + " = undefined;" );
supportjQuery.globalEval( "var " + name + " = true;" );
},
cleanup: function() {
var name,

4
test/unit/ajax.js
View File

@@ -728,7 +728,7 @@ module( "ajax", {
jsonpCallback: "functionToCleanUp",
success: function( data ) {
ok( data["data"], "JSON results returned (GET, custom callback name to be cleaned up)" );
strictEqual( window["functionToCleanUp"], undefined, "Callback was removed (GET, custom callback name to be cleaned up)" );
strictEqual( window["functionToCleanUp"], true, "Callback was removed (GET, custom callback name to be cleaned up)" );
var xhr;
jQuery.ajax({
url: "data/jsonp.php",
@@ -742,7 +742,7 @@ module( "ajax", {
});
xhr.fail(function() {
ok( true, "Ajax error JSON (GET, custom callback name to be cleaned up)" );
strictEqual( window["functionToCleanUp"], undefined, "Callback was removed after early abort (GET, custom callback name to be cleaned up)" );
strictEqual( window["functionToCleanUp"], true, "Callback was removed after early abort (GET, custom callback name to be cleaned up)" );
});
}
}, {