github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-02-01 15:15:00 -05:00
Code Issues Packages Projects Releases Wiki Activity

Event: Normalize mouse event properties in drag events

Browse Source 
DragEvent is a superset of MouseEvent, so we want to fix up mouse
properties like pageX and pageY.

Fixes gh-1925
(cherry picked from commit 389b2ab3b93bfd68ca6c6153a43e11d93ab9ec71)
This commit is contained in:
Aditya Raghavan
2014-12-20 18:41:24 -05:00
committed by Dave Methvin
parent a0bf5bf710
commit 5b0b1b77db
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/event.js
View File

@@ -12,7 +12,7 @@ define([
var rformElems = /^(?:input|select|textarea)$/i,
rkeyEvent = /^key/,
rmouseEvent = /^(?:mouse|pointer|contextmenu)|click/,
rmouseEvent = /^(?:mouse|pointer|contextmenu|drag)|click/,
rfocusMorph = /^(?:focusinfocus|focusoutblur)$/,
rtypenamespace = /^([^.]*)(?:\.(.+)|)/;

19
test/unit/event.js
View File

@@ -2477,6 +2477,25 @@ test("fixHooks extensions", function() {
jQuery.event.fixHooks.click = saved;
});
// IE8 doesn't support custom event triggering natively, but we can skip
// this test in IE8 since a native HTML5 drag event will never occur there.
if ( document.createEvent ) {
test( "drag events copy over mouse related event properties (gh-1925)", function() {
expect( 2 );
var $fixture = jQuery( "<div id='drag-fixture'></div>" ).appendTo( "body" );
$fixture.on( "dragmove", function( evt ) {
ok( "pageX" in evt, "checking for pageX property" );
ok( "pageY" in evt, "checking for pageY property" );
});
fireNative( $fixture[ 0 ], "dragmove" );
$fixture.unbind( "dragmove" ).remove();
});
}
test( "focusin using non-element targets", function() {
expect( 2 );