github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-02-01 18:35:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

CSS: Do not throw on frame elements in FF

Browse Source 
IE9-10 throws on elements created in popups (see #14150), FF meanwhile throws
on frame elements through "defaultView.getComputedStyle" (see #15098)

Use "defaultView" if in the popup which would fix IE issue,
use "window.getComputedStyle" which would fix FF issue.

And everybody wins, except performance, but who cares right?

Fixes #15098
Ref e488d985cf
This commit is contained in:
Oleg Gaidarenko
2014-06-16 01:26:49 +04:00
parent d05f4bda1c
commit 76294e1e9e
2 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/css/curCSS.js
View File

@@ -11,7 +11,14 @@ var getStyles, curCSS,
if ( window.getComputedStyle ) {
getStyles = function( elem ) {
return elem.ownerDocument.defaultView.getComputedStyle( elem, null );
// Support: IE<=11+, Firefox<=30+ (#15098, #14150)
// IE throws on elements created in popups
// FF meanwhile throws on frame elements through "defaultView.getComputedStyle"
if ( elem.ownerDocument.defaultView.opener ) {
return elem.ownerDocument.defaultView.getComputedStyle( elem, null );
}
return window.getComputedStyle( elem, null );
};
curCSS = function( elem, name, computed ) {

23
test/unit/css.js
View File

@@ -1126,4 +1126,27 @@ test( "show() after hide() should always set display to initial value (#14750)",
});
}
})();
test( "Do not throw on frame elements from css method (#15098)", 1, function() {
var frameWin, frameDoc,
frameElement = document.createElement( "iframe" ),
frameWrapDiv = document.createElement( "div" );
frameWrapDiv.appendChild( frameElement );
document.body.appendChild( frameWrapDiv );
frameWin = frameElement.contentWindow;
frameDoc = frameWin.document;
frameDoc.open();
frameDoc.write( "<!doctype html><html><body><div>Hi</div></body></html>" );
frameDoc.close();
frameWrapDiv.style.display = "none";
try {
jQuery( frameDoc.body ).css( "direction" );
ok( true, "It didn't throw" );
} catch ( _ ) {
ok( false, "It did throw" );
}
});
}