github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-02-01 20:05:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

Manipulation: don't auto-insert tbody

Browse Source 
Fixes gh-1835
Closes gh-2021
Ref e984d1c79c
This commit is contained in:
Oleg Gaidarenko
2015-02-11 17:07:29 +03:00
parent b744a50d47
commit 939e755163
2 changed files with 81 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/manipulation.js
View File

@@ -104,12 +104,13 @@ function getAll( context, tag ) {
// Manipulating tables requires a tbody
function manipulationTarget( elem, content ) {
return jQuery.nodeName( elem, "table" ) &&
jQuery.nodeName( content.nodeType !== 11 ? content : content.firstChild, "tr" ) ?
if ( jQuery.nodeName( elem, "table" ) &&
jQuery.nodeName( content.nodeType !== 11 ? content : content.firstChild, "tr" ) ) {
elem.getElementsByTagName("tbody")[0] ||
elem.appendChild( elem.ownerDocument.createElement("tbody") ) :
elem;
return elem.getElementsByTagName( "tbody" )[ 0 ] || elem;
}
return elem;
}
// Replace/restore the type attribute of script elements for safe DOM manipulation

75
test/unit/manipulation.js
View File

@@ -2485,6 +2485,81 @@ test( "Make sure jQuery.fn.remove can work on elements in documentFragment", 1,
equal( fragment.childNodes.length, 0, "div element was removed from documentFragment" );
});
test( "Make sure tr element will be appended to tbody element of table when present", function() {
expect( 1 );
var html,
table = document.createElement( "table" );
table.appendChild( document.createElement( "tbody" ) );
document.getElementById( "qunit-fixture" ).appendChild( table );
jQuery( table ).append( "<tr><td>test</td></tr>" );
// Lowercase and replace spaces to remove possible browser inconsistencies
html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
strictEqual( html, "<tbody><tr><td>test</td></tr></tbody>" );
});
test( "Make sure tr elements will be appended to tbody element of table when present", function() {
expect( 1 );
var html,
table = document.createElement( "table" );
table.appendChild( document.createElement( "tbody" ) );
document.getElementById( "qunit-fixture" ).appendChild( table );
jQuery( table ).append( "<tr><td>1</td></tr><tr><td>2</td></tr>" );
// Lowercase and replace spaces to remove possible browser inconsistencies
html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
strictEqual( html, "<tbody><tr><td>1</td></tr><tr><td>2</td></tr></tbody>" );
});
test( "Make sure tfoot element will not be appended to tbody element of table when present", function() {
expect( 1 );
var html,
table = document.createElement( "table" );
table.appendChild( document.createElement( "tbody" ) );
document.getElementById( "qunit-fixture" ).appendChild( table );
jQuery( table ).append( "<tfoot/>" );
// Lowercase and replace spaces to remove possible browser inconsistencies
html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
strictEqual( html, "<tbody></tbody><tfoot></tfoot>" );
});
test( "Make sure document fragment will be appended to tbody element of table when present", function() {
expect( 1 );
var html,
fragment = document.createDocumentFragment(),
table = document.createElement( "table" ),
tr = document.createElement( "tr" ),
td = document.createElement( "td" );
table.appendChild( document.createElement( "tbody" ) );
document.getElementById( "qunit-fixture" ).appendChild( table );
fragment.appendChild( tr );
tr.appendChild( td );
td.innerHTML = "test";
jQuery( table ).append( fragment );
// Lowercase and replace spaces to remove possible browser inconsistencies
html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
strictEqual( html, "<tbody><tr><td>test</td></tr></tbody>" );
});
test( "Make sure col element is appended correctly", function() {
expect( 1 );