github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-02-01 06:04:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Core: Work around loss of precision from parseFloat

Browse Source 
Fixes #15100
This commit is contained in:
Richard Gibson
2014-06-07 14:22:49 -04:00
parent 6cb17c8ea4
commit b6e99eb43c
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/core.js
View File

@@ -216,7 +216,8 @@ jQuery.extend({
// parseFloat NaNs numeric-cast false positives (null|true|false|"")
// ...but misinterprets leading-number strings, particularly hex literals ("0x...")
// subtraction forces infinities to NaN
return !jQuery.isArray( obj ) && obj - parseFloat( obj ) >= 0;
// adding 1 corrects loss of precision from parseFloat (#15100)
return !jQuery.isArray( obj ) && (obj - parseFloat( obj ) + 1) >= 0;
},
isEmptyObject: function( obj ) {

3
test/unit/core.js
View File

@@ -462,7 +462,7 @@ test("isFunction", function() {
});
test( "isNumeric", function() {
expect( 37 );
expect( 38 );
var t = jQuery.isNumeric,
Traditionalists = /** @constructor */ function(n) {
@@ -490,6 +490,7 @@ test( "isNumeric", function() {
ok( t("4.536"), "Positive floating point string");
ok( t(-2.6), "Negative floating point number");
ok( t(3.1415), "Positive floating point number");
ok( t(1.5999999999999999), "Very precise floating point number" );
ok( t(8e5), "Exponential notation");
ok( t("123e-2"), "Exponential notation string");
ok( t(answer), "Custom .toString returning number");