github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-01-31 09:07:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Effects: Remove additional parameters of easings

Browse Source 
Fixes gh-2367
Closes gh-2376
This commit is contained in:
Thomas Tortorini
2015-06-27 17:18:21 +02:00
committed by Michał Gołębiowski
parent c9cf250daa
commit b7a7dea95f
2 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/effects/Tween.js
View File

@@ -27,17 +27,12 @@ Tween.prototype = {
Tween.propHooks._default.get( this );
},
run: function( percent ) {
var eased,
hooks = Tween.propHooks[ this.prop ];
var hooks = Tween.propHooks[ this.prop ];
if ( this.options.duration ) {
this.pos = eased = jQuery.easing[ this.easing ](
percent, this.options.duration * percent, 0, 1, this.options.duration
);
} else {
this.pos = eased = percent;
}
this.now = ( this.end - this.start ) * eased + this.start;
this.pos = this.options.duration ?
jQuery.easing[ this.easing ]( percent ) :
percent;
this.now = ( this.end - this.start ) * this.pos + this.start;
if ( this.options.step ) {
this.options.step.call( this.elem, this.now, this );

8
test/unit/tween.js
View File

@@ -160,8 +160,7 @@ QUnit.test( "jQuery.Tween - Plain Object", function( assert ) {
assert.equal( tween.now, 90, "Calculated tween" );
assert.ok( easingSpy.calledWith( 0.1, 0.1 * testOptions.duration, 0, 1, testOptions.duration ),
"...using jQuery.easing.linear with back-compat arguments" );
assert.ok( easingSpy.calledWith( 0.1 ), "...using jQuery.easing.linear" );
assert.equal( testObject.test, 90, "Set value" );
tween.run( 1 );
@@ -200,10 +199,7 @@ QUnit.test( "jQuery.Tween - Element", function( assert ) {
eased = 100 - ( jQuery.easing.swing( 0.1 ) * 100 );
assert.equal( tween.now, eased, "Calculated tween" );
assert.ok(
easingSpy.calledWith( 0.1, 0.1 * testOptions.duration, 0, 1, testOptions.duration ),
"...using jQuery.easing.linear with back-compat arguments"
);
assert.ok( easingSpy.calledWith( 0.1 ), "...using jQuery.easing.linear" );
assert.equal(
parseFloat( testElement.style.height ).toFixed( 2 ),
eased.toFixed( 2 ), "Set value"