github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-02-02 23:54:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix weird clone bug and add a unit test to verify

Browse Source
This commit is contained in:
Elijah Manor
2012-08-08 15:31:59 -05:00
parent 0d07e7fc2c
commit d5d8622329
2 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/manipulation.js
View File

@@ -585,11 +585,17 @@ jQuery.extend({
var srcElements,
destElements,
i,
clone;
clone,
fix8908;
if ( jQuery.support.html5Clone || jQuery.isXMLDoc(elem) || !rnoshimcache.test( "<" + elem.nodeName + ">" ) ) {
clone = elem.cloneNode( true );
// Fixes #8909 - By accessing one of the cloned element's computed styles it breaks the
// connection with the source element's styles in IE9/10
if ( elem.nodeType === 1 && window.getComputedStyle ) {
fix8908 = ( window.getComputedStyle( elem, null ) || {} ).backgroundImage;
}
clone = elem.cloneNode( true );
// IE<=8 does not properly clone detached, unknown element nodes
} else {
fragmentDiv.innerHTML = elem.outerHTML;

36
test/unit/manipulation.js
View File

@@ -1907,3 +1907,39 @@ test("checked state is cloned with clone()", function(){
elem.checked = true;
equal( jQuery(elem).clone().attr("id","clone")[0].checked, true, "Checked true state correctly cloned" );
});
test( "Clearing a Cloned Element's Style Shouldn't Clear the Original Element's Style (#8908)", function() {
expect( 8 );
var baseUrl = document.location.href.replace( /([^\/]*)$/, "" );
var styles = [
{ name: "background-attachment", value: [ "fixed" ], expected: [ "scroll" ] },
{ name: "background-color", value: [ "rgb(255, 0, 0)", "rgb(255,0,0)" ], expected: [ "transparent" ] },
{ name: "background-image", value: [ 'url("test.png")', 'url(' + baseUrl + 'test.png)', 'url("' + baseUrl + 'test.png")' ], expected: [ "none" ] },
{ name: "background-position", value: [ "5% 5%" ], expected: [ "0% 0%" ] },
{ name: "background-repeat", value: [ "repeat-y" ], expected: [ "repeat" ] },
{ name: "background-clip", value: [ "content-box" ], expected: [ "border-box" ] },
{ name: "background-origin", value: [ "content-box" ], expected: [ "padding-box" ] },
{ name: "background-size", value: [ "80px 60px" ], expected: [] }
];
jQuery.each( styles, function(index, style) {
var $source, source, $clone;
style.expected = style.expected.concat( [ "", "auto" ] );
$source = jQuery( "<div />" );
source = $source[ 0 ];
if ( source.style[ style.name ] === undefined ) {
ok( true, style.name + ": style isn't supported and therefore not an issue" );
return true;
}
$source.css( style.name, style.value[0] );
$clone = $source.clone();
$clone.css( style.name, "" );
ok( ~jQuery.inArray( $source.css( style.name ), style.value ),
"Clearning clone.css() doesn't affect source.css(): " + style.name +
"; result: " + $source.css( style.name ) +
"; expected: " + style.value.join( "," ) );
});
});