github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-01-25 06:28:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix #11649. Preserve oldIE submit flag when cloning, closes gh-772.

Browse Source
This commit is contained in:
Jason Moon
2012-05-18 16:30:28 -04:00
committed by Dave Methvin
parent 6bf3f20d4e
commit e93f2a89e2
3 changed files with 37 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/event.js
View File

@@ -772,11 +772,11 @@ if ( !jQuery.support.submitBubbles ) {
// Node name check avoids a VML-related crash in IE (#9807)
var elem = e.target,
form = jQuery.nodeName( elem, "input" ) || jQuery.nodeName( elem, "button" ) ? elem.form : undefined;
if ( form && !form._submit_attached ) {
if ( form && !jQuery._data( form, "_submit_attached" ) ) {
jQuery.event.add( form, "submit._submit", function( event ) {
event._submit_bubble = true;
});
form._submit_attached = true;
jQuery._data( form, "_submit_attached", true );
}
});
// return undefined since we don't need an event listener

1
src/manipulation.js
View File

@@ -467,7 +467,6 @@ function cloneFixAttributes( src, dest ) {
// Clear flags for bubbling special change/submit events, they must
// be reattached when the newly cloned events are first activated
dest.removeAttribute( "_submit_attached" );
dest.removeAttribute( "_change_attached" );
}

35
test/unit/event.js
View File

@@ -1062,6 +1062,41 @@ test("trigger(type, [data], [fn])", function() {
form.remove();
});
test( "submit event bubbles on copied forms (#11649)", function(){
expect( 3 );
var $formByClone, $formByHTML,
$testForm = jQuery("#testForm"),
$fixture = jQuery("#qunit-fixture"),
$wrapperDiv = jQuery("<div/>").appendTo( $fixture );
function noSubmit( e ) {
e.preventDefault();
}
function delegatedSubmit() {
ok( true, "Make sure submit event bubbles up." );
return false;
}
// Attach a delegated submit handler to the parent element
$fixture.on( "submit", "form", delegatedSubmit );
// Trigger form submission to introduce the _submit_attached property
$testForm.on( "submit", noSubmit ).find("input[name=sub1]").click();
// Copy the form via .clone() and .html()
$formByClone = $testForm.clone( true, true ).removeAttr("id");
$formByHTML = jQuery( $fixture.html() ).filter("#testForm").removeAttr("id");
$wrapperDiv.append( $formByClone, $formByHTML );
// Check submit bubbling on the copied forms
$wrapperDiv.find("form").on( "submit", noSubmit ).find("input[name=sub1]").click();
// Clean up
$wrapperDiv.remove();
$fixture.off( "submit", "form", delegatedSubmit );
});
test("trigger(eventObject, [data], [fn])", function() {
expect(28);