github/lodestar
1
1
Fork 0
mirror of https://github.com/ChainSafe/lodestar.git synced 2026-01-08 23:28:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid calling committee selection apis if there are no duties (#8708)

Browse Source 
Since https://github.com/ChainSafe/lodestar/pull/8669 we might call the
committee selection apis even if we don't have any duties which is
unnecessary and charon doesn't like it.

```
lodestar-1  | Dec-19 16:16:47.001[]                error: Error on sync committee aggregation selection slot=13278082 - JSON is not an array
lodestar-1  | Error: JSON is not an array
lodestar-1  |     at value_fromJsonArray (file:///usr/app/node_modules/@chainsafe/ssz/src/type/arrayBasic.ts:162:11)
lodestar-1  |     at ListCompositeType.fromJson (file:///usr/app/node_modules/@chainsafe/ssz/src/type/array.ts:121:12)
lodestar-1  |     at ApiResponse.value (file:///usr/app/packages/api/src/utils/client/response.ts:115:51)
lodestar-1  |     at SyncCommitteeDutiesService.runDistributedAggregationSelectionTasks (file:///usr/app/packages/validator/src/services/syncCommitteeDuties.ts:385:36)
lodestar-1  |     at processTicksAndRejections (node:internal/process/task_queues:103:5)
```
This commit is contained in:
Nico Flaig
2025-12-19 19:03:16 +01:00
committed by GitHub
parent 493cc12d2f
commit 39dac0f03d
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/validator/src/services/attestationDuties.ts
View File

@@ -453,6 +453,10 @@ export class AttestationDutiesService {
* 3. Mutate duty objects to set selection proofs for aggregators
*/
private async runDistributedAggregationSelectionTasks(duties: AttDutyAndProof[], epoch: Epoch): Promise<void> {
if (duties.length === 0) {
return;
}
const partialSelections: routes.validator.BeaconCommitteeSelection[] = duties.map(
({duty, partialSelectionProof}) => ({
validatorIndex: duty.validatorIndex,

4
packages/validator/src/services/syncCommitteeDuties.ts
View File

@@ -355,6 +355,10 @@ export class SyncCommitteeDutiesService {
* 3. Mutate duty objects to set selection proofs for aggregators
*/
private async runDistributedAggregationSelectionTasks(duties: SyncDutyAndProofs[], slot: number): Promise<void> {
if (duties.length === 0) {
return;
}
const partialSelections: routes.validator.SyncCommitteeSelection[] = [];
for (const {duty, selectionProofs} of duties) {