github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove direct deps from build id computation.

Browse Source 
We don't need the direct deps in the build id: if I'm a package and my
direct dependencies change, then no one who depends on me has to
rebuild. On the other hand, if my plugin's (transitive) dependencies
change, then anyone who directly depends on me does need to rebuild
because my plugins need to re-run.
This commit is contained in:
Emily Stark
2014-04-01 10:57:52 -07:00
parent 42ef8d3714
commit 01ea1feee0
1 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tools/unipackage.js
View File

@@ -890,21 +890,9 @@ _.extend(Unipackage.prototype, {
// existing version has a build identifier already.
addBuildIdentifierToVersion: function () {
var self = this;
// Gather all the dependencies' versions and organize them into
// arrays. We use arrays to avoid relying on the order of
// Gather all the plugin dependencies' versions and organize them
// into arrays. We use arrays to avoid relying on the order of
// stringified object keys.
var directDeps = [];
_.each(
self._buildTimeDirectDependenciesWithBuildIds(),
function (version, packageName) {
directDeps.push([packageName, version]);
}
);
// Sort direct dependencies by package name (which is the "0" property
// of each element in the array).
directDeps = _.sortBy(directDeps, "0");
var pluginDeps = [];
_.each(
self._buildTimePluginDependenciesWithBuildIds(),
@@ -935,7 +923,6 @@ _.extend(Unipackage.prototype, {
// Stick all our info into one big array, stringify it, and hash it.
var buildIdInfo = [
directDeps,
pluginDeps,
watchFiles
];