github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

unbreak created and destroyed callbacks

Browse Source 
there is no DomRange available then, so don't
set firstNode and lastNode on the template instance
This commit is contained in:
Avital Oliver
2013-09-18 13:51:04 -07:00
parent 665cfb269d
commit 01fd48cb88
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/ui/base.js
View File

@@ -1145,13 +1145,20 @@ updateTemplateInstance = function (comp) {
// on demand.
var tmpl = comp.templateInstance;
tmpl.data = getComponentData(comp);
tmpl.firstNode = comp.dom.startNode().nextSibling;
tmpl.lastNode = comp.dom.endNode().previousSibling;
// Catch the case where the DomRange is empty and we'd
// otherwise pass the out-of-order nodes (end, start)
// as (firstNode, lastNode).
if (tmpl.lastNode.nextSibling === tmpl.firstNode)
tmpl.lastNode = tmpl.firstNode;
if (comp.dom) {
tmpl.firstNode = comp.dom.startNode().nextSibling;
tmpl.lastNode = comp.dom.endNode().previousSibling;
// Catch the case where the DomRange is empty and we'd
// otherwise pass the out-of-order nodes (end, start)
// as (firstNode, lastNode).
if (tmpl.lastNode.nextSibling === tmpl.firstNode)
tmpl.lastNode = tmpl.firstNode;
} else {
// on 'created' or 'destroyed' callbacks we don't have a DomRange
tmpl.firstNode = null;
tmpl.lastNode = null;
}
};
_extend(UI.Component, {