github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11897 from meteor/always-minify-css-resource

Browse Source 
Pass lazy css resources to minifier in development
This commit is contained in:
Filipe Névola
2022-02-10 02:01:17 +04:00
committed by GitHub
parent b66b693c02 35dd7ab257
commit 127147d8ae
6 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/isobuild/bundler.js
View File

@@ -1120,8 +1120,7 @@ class Target {
// Takes a CssOutputResource and returns a string of minified CSS,
// or null to indicate no minification occurred.
minifyCssResource: (resource) => {
if (! minifiersByExt.css ||
minifyMode === "development") {
if (! minifiersByExt.css) {
// Indicates the caller should use the original resource.data
// without minification.
return null;

1
tools/tests/apps/custom-minifier/body.html
View File

@@ -1,4 +1,5 @@
<body>
<div class="production_css">Text for prod</div>
<div class="development_css">Text for devel</div>
<div class="minified_lazy">Text for imported</div>
</body>

4
tools/tests/apps/custom-minifier/code.js
View File

@@ -1,6 +1,8 @@
if (Meteor.isClient) {
require('./imports/imported.css');
Meteor.startup(function () {
['production_css', 'development_css'].forEach(cls => {
['production_css', 'development_css', 'minified_lazy'].forEach(cls => {
var color = getComputedStyle(document.querySelectorAll('.' + cls)[0]).color;
Meteor.call('print', cls + ': ' + color);
});

3
tools/tests/apps/custom-minifier/imports/imported.css Normal file
View File

@@ -0,0 +1,3 @@
.lazy-resource {
color: rgb(0, 256, 0);
}

3
tools/tests/apps/custom-minifier/packages/custom-minifier/plugin/minify.js
View File

@@ -29,6 +29,7 @@ CustomMinifier.prototype.processFilesForBundle = function (files, options) {
data: contents
});
} else {
contents = contents.replace(/lazy-resource/g, 'minified_lazy');
file.addStylesheet({
data: contents
});
@@ -37,5 +38,3 @@ CustomMinifier.prototype.processFilesForBundle = function (files, options) {
Plugin.nudge();
});
};

2
tools/tests/custom-minifier.js
View File

@@ -22,6 +22,7 @@ selftest.define('custom minifier - devel vs prod', function (options) {
run.match('production_css: rgb(255, 0, 0)');
run.match('development_css: rgb(0, 0, 0)');
run.match('minified_lazy: rgb(0, 255, 0)');
run.match('Message (client): production_js');
run.stop();
@@ -43,6 +44,7 @@ selftest.define('custom minifier - devel vs prod', function (options) {
run.match('production_css: rgb(0, 0, 0)');
run.match('development_css: rgb(255, 0, 0)');
run.match('minified_lazy: rgb(0, 255, 0)');
run.match('Message (client): development_js');
run.stop();