github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make meteor shell not crash when piped from another command.

Browse Source 
This commit makes possible but but doesn't fully solve the problem of
using `meteor shell` within shell scripts. See #5055 for more
details.

Closes #5056
This commit is contained in:
Avital Oliver
2015-08-28 09:34:28 -07:00
parent f81e0f53b3
commit 128fb7ce55
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
History.md
View File

@@ -230,6 +230,8 @@
### `meteor` command-line tool
* `meteor shell` no longer crashes when piped from another command.
* Avoid a race condition in `meteor --test` and work with newer versions of the
Velocity package. #3957

8
tools/shell-client.js
View File

@@ -103,7 +103,9 @@ Cp.setUpSocket = function setUpSocket(sock, key) {
process.stderr.write(shellBanner());
process.stdin.pipe(sock);
process.stdin.setRawMode(true);
if (process.stdin.setRawMode) { // https://github.com/joyent/node/issues/8204
process.stdin.setRawMode(true);
}
}
function onClose() {
@@ -125,7 +127,9 @@ Cp.setUpSocket = function setUpSocket(sock, key) {
function tearDown() {
self.connected = false;
process.stdin.setRawMode(false);
if (process.stdin.setRawMode) { // https://github.com/joyent/node/issues/8204
process.stdin.setRawMode(false);
}
process.stdin.unpipe(sock);
sock.unpipe(process.stdout);
sock.removeListener("connect", onConnect);