github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-01-11 00:28:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Issue with meteor publish with update option

Browse Source 
It was missing an await in the update readme function.

Adding tests for this is an issue because of this snippet 3747d4cb87/tools/cli/commands-packages.js (L175-L184) and other parts that require or do some kind of check with the network

Maybe for the future think a way of mocking or being able to do tests in functions and not system tests.

Increase of types could help too.
This commit is contained in:
Gabriel Grubba
2024-11-13 19:59:59 -03:00
parent 5e5d437c6a
commit 257bf14b69
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/packaging/package-client.js
View File

@@ -466,7 +466,7 @@ exports.handlePackageServerConnectionError = function (error) {
};
// Update the package metdata in the server catalog. Chane the docs,
// Update the package metadata in the server catalog. Change the docs,
// descriptions and the Git URL to new values.
//
// options:
@@ -537,7 +537,7 @@ exports.updatePackageMetadata = async function (options) {
// Upload the new Readme.
await buildmessage.enterJob('uploading documentation', async function () {
var readmePath = saveReadmeToTmp(readmeInfo);
var readmePath = await saveReadmeToTmp(readmeInfo);
var uploadInfo =
await callPackageServerBM(conn, "createReadme", versionIdentifier);
if (!uploadInfo) {