github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't throw an updated-buffered doc right away. It can go to published or back to buffer.

Browse Source
This commit is contained in:
Slava Kim
2014-02-18 16:37:31 -08:00
parent e4eb3e3c75
commit 3871c92181
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/mongo-livedata/oplog_observe_driver.js
View File

@@ -305,13 +305,22 @@ _.extend(OplogObserveDriver.prototype, {
self._justUpdatedBuffer = false;
}
} else if (bufferedBefore) {
// after the change we can't know if doc is still in the buffer limit
// w/o querying mongo, so just remove it from buffer
self._removeBuffered(id);
// but it can move into published now, check it
oldDoc = self._unpublishedBuffer.get(id);
// remove the old version manually so we don't trigger the querying
// immediately
self._unpublishedBuffer.remove(id);
var maxPublished = self._published.get(self._published.maxElementId());
if (comparator(newDoc, maxPublished) < 0)
var maxBuffered = self._unpublishedBuffer.size() && self._unpublishedBuffer.get(self._unpublishedBuffer.maxElementId());
// the buffered doc was updated, it could move to published
if (comparator(newDoc, maxPublished) < 0) {
self._addPublished(id, newDoc);
} else if (self._justUpdatedBuffer || (maxBuffered && comparator(newDoc, maxBuffered) < 0)) {
// stays in buffer
self._unpublishedBuffer.set(id, newDoc);
} else {
self._justUpdatedBuffer = false;
}
} else {
throw new Error("cachedBefore implies either of publishedBefore or bufferedBefore is true.");
}