github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Move upgrade cost component earlier

Browse Source
This commit is contained in:
David Greenspan
2015-02-06 13:48:24 -08:00
parent ead0d8ea0b
commit 47eeb6fd02
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/constraint-solver/solver.js
View File

@@ -230,6 +230,9 @@ CS.Solver.prototype._generateCostFunction = function () {
// are supposed to be optimizing about the version and with what
// priority.
var costFunc = new CS.Solver.CostFunction();
costFunc.addComponent('upgrade_oldness');
// 1 if we change the major version of a root dep with previous version
costFunc.addComponent('previous_root_major');
// 1 if we move a root dep backwards in the same major version
@@ -244,12 +247,6 @@ CS.Solver.prototype._generateCostFunction = function () {
costFunc.addComponent('previous_indirect_change');
costFunc.addComponent('previous_indirect_distance');
// XXX probably need some more nuance here.
// In general, we want packages we're upgrading and new root dependencies
// (just added or in case of no previous solution) to be as new as possible,
// so we penalize oldness. New indirect dependencies should be as old as
// possible, so we penalize newness.
costFunc.addComponent('upgrade_oldness');
costFunc.addComponent('new_root_oldness');
costFunc.addComponent('new_indirect_major_newness');
costFunc.addComponent('new_indirect_minor_newness');