github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Always record ResourceSlot errors in InputFile#addError.

Browse Source
This commit is contained in:
Ben Newman
2018-06-26 13:54:09 -04:00
parent 9f7ef9cdb1
commit 5abc8fbdd2
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tools/isobuild/compiler-plugin.js
View File

@@ -542,17 +542,8 @@ class InputFile extends buildPluginModule.InputFile {
}
_reportError(message, info) {
if (this.getFileOptions().lazy === true) {
// Files with fileOptions.lazy === true were not explicitly added to
// the source batch via api.addFiles or api.mainModule, so any
// compilation errors should not be fatal until the files are
// actually imported by the ImportScanner. Attempting compilation is
// still important for lazy files that might end up being imported
// later, which is why we defang the error here, instead of avoiding
// compilation preemptively. Note also that exceptions thrown by the
// compiler will still cause build errors.
this._resourceSlot.addError(message, info);
} else {
this._resourceSlot.addError(message, info);
if (! this.getFileOptions().lazy) {
super._reportError(message, info);
}
}