github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid NPE if specified version not found

Browse Source
This commit is contained in:
Justin SB
2014-10-17 07:45:54 -07:00
parent 88f900509c
commit 6375d30a4c
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tools/commands-packages.js
View File

@@ -1182,7 +1182,7 @@ main.registerCommand({
versions = [full[1]];
}
versionRecords = _.map(versions, getRelevantRecord);
if (full.length > 1 && versionRecords.length == 1) {
if (full.length > 1 && versionRecords.length == 1 && versionRecords[0]) {
showName += Console.bold("@" + versionRecords[0].version);
}
} else {
@@ -1192,7 +1192,7 @@ main.registerCommand({
doOrDie(function () {
versionRecords = [catalog.official.getReleaseVersion(name, full[1])];
});
if (versionRecords.length == 1) {
if (versionRecords.length == 1 && versionRecords[0]) {
showName += Console.bold("@" + versionRecords[0].version);
}
} else {
@@ -1214,16 +1214,17 @@ main.registerCommand({
Console.error("No versions of package" + name + " exist.");
}
} else {
if (showName) {
Console.info("Showing", showName, "\n");
}
var lastVersion = versionRecords[versionRecords.length - 1];
if (!lastVersion && full.length > 1) {
Console.error(
full[1] + ": unknown version of " + name);
return 1;
}
if (showName) {
Console.info("Showing", showName, "\n");
}
var unknown = "< unknown >";
_.each(versionRecords, function (v) {
// Don't show versions that we shouldn't be showing.