github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Set stopped computation to null instead of delete (#7326) (#7328)

Browse Source 
* Set stopped computation to null instead of delete (#7326)

Delete can be very slow. Setting the stopped computation property to null instead brings a speed gain of 3-10x.

http://bertanguven.com/preventing-memory-leaks-in-javascript-null-vs-delete

* add generated npm-shrinkwrap.json

* Remove computation tracking from Tracker.
This commit is contained in:
Ilari Patrikka
2016-07-13 01:37:48 +03:00
committed by Ben Newman
parent bc12938206
commit 768d82eb6c
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/tracker/tracker.js
View File

@@ -26,13 +26,6 @@ Tracker.active = false;
*/
Tracker.currentComputation = null;
// References to all computations created within the Tracker by id.
// Keeping these references on an underscore property gives more control to
// tooling and packages extending Tracker without increasing the API surface.
// These can used to monkey-patch computations, their functions, use
// computation ids for tracking, etc.
Tracker._computations = {};
var setCurrentComputation = function (c) {
Tracker.currentComputation = c;
Tracker.active = !! c;
@@ -203,9 +196,6 @@ Tracker.Computation = function (f, parent, onError) {
self._onError = onError;
self._recomputing = false;
// Register the computation within the global Tracker.
Tracker._computations[self._id] = self;
var errored = true;
try {
self._compute();
@@ -300,8 +290,6 @@ Tracker.Computation.prototype.stop = function () {
if (! self.stopped) {
self.stopped = true;
self.invalidate();
// Unregister from global Tracker.
delete Tracker._computations[self._id];
for(var i = 0, f; f = self._onStopCallbacks[i]; i++) {
Tracker.nonreactive(function () {
withNoYieldsAllowed(f)(self);