github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix the logic for calculating the final location for a moved item in observe-sequence

Browse Source
This commit is contained in:
Slava Kim
2015-03-10 15:04:47 -07:00
parent c247e2526f
commit 7a61abdaed
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/observe-sequence/observe_sequence.js
View File

@@ -195,13 +195,28 @@ var diffArray = function (lastSeqArray, seqArray, callbacks) {
before);
},
movedBefore: function (id, before) {
if (id === before)
return;
var prevPosition = posCur[idStringify(id)];
var position = before ? posCur[idStringify(before)] : lengthCur - 1;
var position = before ? posCur[idStringify(before)] : lengthCur;
// Moving the item forward. The new element is losing one position as it
// was removed from the old position before being inserted at the new
// position.
// Ex.: 0 *1* 2 3 4
// 0 2 3 *1* 4
// The original issued callback is "1" before "4".
// The position of "1" is 1, the position of "4" is 4.
// The generated move is (1) -> (3)
if (position > prevPosition) {
position--;
}
_.each(posCur, function (pos, id) {
if (pos >= prevPosition && pos <= position)
if (pos > prevPosition && pos < position)
posCur[id]--;
else if (pos <= prevPosition && pos >= position)
else if (pos < prevPosition && pos >= position)
posCur[id]++;
});