github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Better assertions in the oplog code

Browse Source
This commit is contained in:
Slava Kim
2014-02-23 20:03:38 -08:00
parent 90ba50acb7
commit 7c202f6004
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/mongo-livedata/oplog_observe_driver.js
View File

@@ -270,8 +270,8 @@ _.extend(OplogObserveDriver.prototype, {
// and the effect of limit enforced.
_removeMatching: function (id) {
var self = this;
if (!self._published.has(id) && !self._limit)
throw Error("tried to remove something unpublished " + id); // xcxc fix this error msg
if (! self._published.has(id) && ! self._limit)
throw Error("tried to remove something matching but not cached " + id);
if (self._published.has(id)) {
self._removePublished(id);
@@ -448,9 +448,10 @@ _.extend(OplogObserveDriver.prototype, {
if (self._published.has(id) || (self._limit && self._unpublishedBuffer.has(id)))
self._removeMatching(id);
} else if (op.op === 'i') {
// xcxc what if buffer has it?
if (self._published.has(id))
throw new Error("insert found for already-existing ID");
throw new Error("insert found for already-existing ID in published");
if (self._unpublishedBuffer && self._unpublishedBuffer.has(id))
throw new Error("insert found for already-existing ID in buffer");
// XXX what if selector yields? for now it can't but later it could have
// $where