github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix template_tests for IE 7

Browse Source
This commit is contained in:
David Greenspan
2012-08-21 02:42:00 -04:00
parent a326aa367f
commit 7eb81ebffb
2 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/templating/templating_tests.html
View File

@@ -244,7 +244,7 @@
<span class="e">x</span>
<span class="z">x</span>
<span class="f">x</span>
{{var}}
<u>{{var}}</u>
</template>
<template name="test_template_helpers_a">
@@ -256,7 +256,7 @@
</template>
<template name="test_template_helpers_c">
{{name}}{{arity}}{{toString}}{{length}}{{var}}
{{name}}{{arity}}{{toString}}{{length}}{{var}}x
</template>
<template name="test_template_events_a">

25
packages/templating/templating_tests.js
View File

@@ -504,8 +504,9 @@ Tinytest.add("templating - matching in list", function (test) {
_.extend(Template.test_listmatching_a1, {
create: function () { buf.push('+'); },
render: function () {
var letter = DomUtils.rangeToHtml(this.firstNode,
this.lastNode).match(/\S+/)[0];
var letter = canonicalizeHtml(
DomUtils.rangeToHtml(this.firstNode,
this.lastNode).match(/\S+/)[0]);
buf.push('*'+letter);
},
destroy: function () { buf.push('-'); }
@@ -636,7 +637,8 @@ Tinytest.add("templating - preserve", function (test) {
var div = OnscreenDiv(Meteor.render(tmpl));
Meteor.flush();
test.equal(div.node().lastChild.nodeValue.match(/\S+/)[0], 'foo');
test.equal(DomUtils.find(div.node(), 'u').firstChild.nodeValue.match(
/\S+/)[0], 'foo');
var spans1 = {};
_.each(DomUtils.findAll(div.node(), 'span'), function (sp) {
spans1[sp.className] = sp;
@@ -644,7 +646,8 @@ Tinytest.add("templating - preserve", function (test) {
R.set('bar');
Meteor.flush();
test.equal(div.node().lastChild.nodeValue.match(/\S+/)[0], 'bar');
test.equal(DomUtils.find(div.node(), 'u').firstChild.nodeValue.match(
/\S+/)[0], 'bar');
var spans2 = {};
_.each(DomUtils.findAll(div.node(), 'span'), function (sp) {
spans2[sp.className] = sp;
@@ -687,14 +690,24 @@ Tinytest.add("templating - helpers", function (test) {
});
div = OnscreenDiv(Meteor.render(tmpl));
test.equal(div.text().match(/\S+/)[0], 'ABC4D');
var txt = div.text().match(/\S+/)[0];
test.isTrue(txt.match(/^ABC?4D$/));
// We don't get 'C' (the ability to name a helper {{toString}})
// in IE < 9 because of the famed DontEnum bug. This could be
// fixed but it would require making all the code that handles
// the dictionary of helpers be DontEnum-aware. In practice,
// the Object prototype method names (toString, hasOwnProperty,
// isPropertyOf, ...) make poor helper names and are unlikely
// to be used in apps.
test.expect_fail();
test.equal(txt, 'ABC4D');
div.kill();
Meteor.flush();
// test that helpers don't "leak"
tmpl = Template.test_template_helpers_c;
div = OnscreenDiv(Meteor.render(tmpl));
test.equal(div.text(), '');
test.equal(div.text(), 'x');
div.kill();
Meteor.flush();
});