github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

More on deep/shallow cloning

Browse Source
This commit is contained in:
Slava Kim
2013-11-05 16:58:58 -08:00
committed by David Glasser
parent 034d2e628b
commit 8a4b58d987
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/mongo-livedata/oplog.js
View File

@@ -48,6 +48,7 @@ MongoConnection.prototype._observeChangesWithOplog = function (
if (published.has(id))
throw Error("tried to add something already published " + id);
published.set(id, fields);
// projection will deep copy object
callbacks.added && callbacks.added(id, projection(fields));
};
@@ -75,6 +76,7 @@ MongoConnection.prototype._observeChangesWithOplog = function (
if (callbacks.changed) {
var changed = LocalCollection._makeChangedFields(
newDoc, oldDoc);
// projection will deep copy the changed object
changed = projection(changed);
if (!_.isEmpty(changed))
callbacks.changed(id, changed);
@@ -169,7 +171,8 @@ MongoConnection.prototype._observeChangesWithOplog = function (
// Oh great, we actually know what the document is, so we can apply
// this directly.
// XXX this assumes no field filtering
var newDoc = _.clone(published.get(id));
// XXX get rid of this deep clone once we run it though projection
var newDoc = EJSON.clone(published.get(id));
newDoc._id = id;
LocalCollection._modify(newDoc, op.o);
handleDoc(id, newDoc);