github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't crash on template destroyed callback

Browse Source
This commit is contained in:
Avital Oliver
2013-10-08 15:02:52 -07:00
parent 1a1f083186
commit 8df574c68a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/ui/base.js
View File

@@ -1156,13 +1156,13 @@ updateTemplateInstance = function (comp) {
var tmpl = comp.templateInstance;
tmpl.data = getComponentData(comp);
if (comp.dom) {
if (comp.dom && !comp.isDestroyed) {
tmpl.firstNode = comp.dom.startNode().nextSibling;
tmpl.lastNode = comp.dom.endNode().previousSibling;
// Catch the case where the DomRange is empty and we'd
// otherwise pass the out-of-order nodes (end, start)
// as (firstNode, lastNode).
if (tmpl.lastNode.nextSibling === tmpl.firstNode)
if (tmpl.lastNode && tmpl.lastNode.nextSibling === tmpl.firstNode)
tmpl.lastNode = tmpl.firstNode;
} else {
// on 'created' or 'destroyed' callbacks we don't have a DomRange
@@ -1234,6 +1234,7 @@ UI.Component.parented = function () {
// XXX
UI.Component.removed = function () {
var self = this;
self.isDestroyed = true;
if (self.destroyed) {
updateTemplateInstance(self);
self.destroyed.call(self.templateInstance);