github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8951 from meteor/abernix/clear-password-on-retry

Browse Source 
Clear credentials before retry on initial `meteor deploy` password failure.
This commit is contained in:
Ben Newman
2017-08-02 08:42:33 -07:00
committed by GitHub
parent 82ae87184f 661b6f74e9
commit 94c0cd00cd
2 changed files with 32 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tools/meteor-services/auth.js
View File

@@ -508,6 +508,7 @@ var doInteractivePasswordLogin = function (options) {
} else {
loginFailed();
if (options.retry) {
delete loginData.password;
Console.error();
continue;
} else {

31
tools/tests/login.js
View File

@@ -122,3 +122,34 @@ selftest.define("login", ['net'], function () {
run.matchErr("Login failed");
run.expectExit(1);
});
// This is a Galaxy-related command (deploy), but still pretty auth-y.
selftest.define("login on deploy", ['net'], function () {
const s = new Sandbox;
const appName = testUtils.randomAppName();
s.createApp(appName, "standard-app");
s.cd(appName);
let run = s.run("deploy", appName);
run.matchErr(/You must be logged in to deploy/);
run.matchErr("Email:");
run.write("test@test.com\n");
run.matchErr("Logging in as test.");
run.matchErr("Password:");
run.write("SoVeryWrong\n");
run.waitSecs(commandTimeoutSecs);
run.matchErr("Login failed");
run.matchErr("Password:");
run.write("testtest\n");
run.waitSecs(commandTimeoutSecs);
run.match("Talking to Galaxy servers");
// "test" user can't actually deploy, so it will still fail.
run.expectExit(1);
});