github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Correct behavior for setting buildMode/NODE_ENV

Browse Source
This commit is contained in:
Tom Coleman
2016-03-14 11:18:23 +11:00
parent 3a98d04b71
commit 96c802edb4
1 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tools/runners/run-all.js
View File

@@ -280,20 +280,32 @@ exports.run = function (options) {
// Ensure process.env.NODE_ENV matches the build mode, with the following precedence:
// 1. Passed in build mode (if development or production)
// 2. Existing process.env.NODE_ENV (if it's valid)
// 3. Default to development
let nodeEnv = process.env.NODE_ENV;
// 3. Default to development (in both cases) otherwise
// NOTE: because this code only runs when using `meteor run` or `meteor test[-packages`,
// We *don't* end up defaulting NODE_ENV in this way when bundling/deploying.
// In those cases, it will default to "production" in packages/meteor/*_env.js
// We *override* NODE_ENV if build mode is one of these values
let buildMode = runOptions.buildOptions.buildMode;
if (buildMode === "development" || buildMode === "production") {
process.env.NODE_ENV = buildMode;
} else if (nodeEnv === "development" || nodeEnv === "production") {
runOptions.buildOptions.buildMode = nodeEnv;
} else {
runOptions.buildOptions.buildMode = "development";
if (! nodeEnv) {
process.env.NODE_ENV = "development";
}
let nodeEnv = process.env.NODE_ENV;
// We *never* override buildMode (it can be "test")
if (!buildMode) {
if (nodeEnv === "development" || nodeEnv === "production") {
runOptions.buildOptions.buildMode = nodeEnv;
} else {
runOptions.buildOptions.buildMode = "development";
}
}
if (!nodeEnv) {
process.env.NODE_ENV = "development";
}
var runner = new Runner(runOptions);
runner.start();
var result = promise.await();