Record package usage on meteor bundle

Also eliminated arguments that weren't used anywhere,
and removed an XXX comment that was false (recordPackages
doesn't use buildmessage to report connection failures)
This commit is contained in:
Avital Oliver
2014-08-13 13:55:08 -07:00
parent 889cc75a1d
commit aff7dfdb50
4 changed files with 14 additions and 6 deletions

View File

@@ -493,6 +493,15 @@ main.registerCommand({
return 1;
}
var statsMessages = buildmessage.capture(function () {
stats.recordPackages();
});
if (statsMessages.hasMessages()) {
process.stdout.write("Error recording package list:\n" +
statsMessages.formatMessages());
// ... but continue;
}
var bundler = require(path.join(__dirname, 'bundler.js'));
var bundleResult = bundler.bundle({
outputPath: bundlePath,

View File

@@ -209,7 +209,7 @@ exports.deploy = function (options) {
stats.recordPackages();
});
if (statsMessages.hasMessages()) {
process.stdout.write("Error talking to stats server:\n" +
process.stdout.write("Error recording package list:\n" +
statsMessages.formatMessages());
// ... but continue;
}

View File

@@ -398,10 +398,10 @@ var bundleAndDeploy = function (options) {
if (options.recordPackageUsage) {
var statsMessages = buildmessage.capture(function () {
stats.recordPackages(options.appDir);
stats.recordPackages();
});
if (statsMessages.hasMessages()) {
process.stdout.write("Error talking to stats server:\n" +
process.stdout.write("Error recording package list:\n" +
statsMessages.formatMessages());
// ... but continue;
}

View File

@@ -448,11 +448,10 @@ _.extend(AppRunner.prototype, {
var bundlePath = path.join(self.appDir, '.meteor', 'local', 'build');
if (self.recordPackageUsage) {
var statsMessages = buildmessage.capture(function () {
stats.recordPackages(self.appDir);
stats.recordPackages();
});
if (statsMessages.hasMessages()) {
// XXX so this happens any time you're offline?
process.stdout.write("Error talking to stats server:\n" +
process.stdout.write("Error recording package list:\n" +
statsMessages.formatMessages());
// ... but continue;
}