mirror of
https://github.com/meteor/meteor.git
synced 2026-05-02 03:01:46 -04:00
Fix glasser's "actual bug"
That's what we've been calling it.
To see this break and then work, add the following line above
the comment that begins `// lock down versions...`:
```
self.solution = logic.solveAssuming('bar');
```
And then run the test "previous solution no longer needed"
in input-tests.js.
The old code would lock down "bar", including the fact that it
is in the current solution. The new code only locks down the version
number in the case where "bar" is used, so it is able to be optimized
away.
This commit is contained in:
@@ -589,7 +589,7 @@ CS.Solver.prototype.getSolution = function (options) {
|
||||
if (input.isRootDependency(package) ||
|
||||
input.isInPreviousSolution(package) ||
|
||||
input.isUpgrading(package)) {
|
||||
logic.require(pvVar(package, v));
|
||||
logic.require(Logic.implies(package, pvVar(package, v)));
|
||||
}
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user