github/meteor
1
1
Fork 0
mirror of https://github.com/meteor/meteor.git synced 2026-05-02 03:01:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove target directory in files.rename to avoid Windows EPERM errors.

Browse Source 
These errors are especially harmful because they cause files.rename to
fall back to copying rather than atomically renaming, which is both much
slower and not even remotely atomic.
This commit is contained in:
Ben Newman
2017-10-08 19:59:56 -04:00
parent e0666e7462
commit b8ee80e1fc
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tools/fs/files.js
View File

@@ -1755,15 +1755,21 @@ files.existsSync = function (path, callback) {
};
if (files.isWindowsLikeFilesystem()) {
var rename = files.rename;
const rename = files.rename;
files.rename = function (from, to) {
// retries are necessarily only on Windows, because the rename call can fail
// with EBUSY, which means the file is "busy"
var maxTries = 10;
var success = false;
// Retries are necessary only on Windows, because the rename call can
// fail with EBUSY, which means the file is in use.
let maxTries = 10;
let success = false;
const osTo = files.convertToOSPath(to);
while (! success && maxTries-- > 0) {
try {
// Despite previous failures, the top-level destination directory
// may have been successfully created, so we must remove it to
// avoid moving the source file *into* the destination directory.
rimraf.sync(osTo);
rename(from, to);
success = true;
} catch (err) {
@@ -1772,6 +1778,7 @@ if (files.isWindowsLikeFilesystem()) {
}
}
}
if (! success) {
files.cp_r(from, to);
files.rm_recursive(from);